Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vecchia approximation #147

Merged

Conversation

samanklesaria
Copy link
Contributor

I thought I might add the Vecchia approximation, as described in https://arxiv.org/pdf/2102.13299.pdf.

Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this @samanklesaria . Will be good to have!

Does the Vecchia approximation provide an approximation to the log marginal likelihood? Would be great to have that available if possible.

src/NearestNeighborsModule.jl Outdated Show resolved Hide resolved
src/NearestNeighborsModule.jl Show resolved Hide resolved
src/NearestNeighborsModule.jl Show resolved Hide resolved
src/NearestNeighborsModule.jl Outdated Show resolved Hide resolved
test/NearestNeighborsModule.jl Outdated Show resolved Hide resolved
@willtebbutt
Copy link
Member

@samanklesaria please do let me know when this is ready for another review.

@samanklesaria
Copy link
Contributor Author

@willtebbutt all set for another review! I don't know why all the CI jobs are failing, but it seems to be unrelated to the code here.

Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the PR. I've made a few cosmetic remarks, but I think we're nearly ready to go now.

src/ApproximateGPs.jl Outdated Show resolved Hide resolved
src/NearestNeighborsModule.jl Outdated Show resolved Hide resolved
src/NearestNeighborsModule.jl Outdated Show resolved Hide resolved
src/NearestNeighborsModule.jl Outdated Show resolved Hide resolved
src/NearestNeighborsModule.jl Outdated Show resolved Hide resolved
src/NearestNeighborsModule.jl Outdated Show resolved Hide resolved
src/NearestNeighborsModule.jl Outdated Show resolved Hide resolved
src/NearestNeighborsModule.jl Outdated Show resolved Hide resolved
src/NearestNeighborsModule.jl Outdated Show resolved Hide resolved
test/NearestNeighborsModule.jl Outdated Show resolved Hide resolved
@willtebbutt
Copy link
Member

Ah, sorry, you'll need to import log2\pi from IrrationalConstants.jl -- that's causing test failures in your tests at the minute.

@samanklesaria
Copy link
Contributor Author

My gradient tests are failing now- investigating it.

@samanklesaria
Copy link
Contributor Author

Everything seems to be working! Thanks for the suggestions.

@willtebbutt
Copy link
Member

Wonderful -- just a couple of formatting suggestions to fix, then we can merge.

@samanklesaria
Copy link
Contributor Author

Are the changes from JuliaFormatter enough, or should I fix other formatting issues as well?

@willtebbutt
Copy link
Member

I'm going to merge as-is if you're happy @samanklesaria -- the AD issues will need to be addressed in another PR.

@samanklesaria
Copy link
Contributor Author

Sounds good! I can't seem to reproduce the AD issues. Might have been a quirk with an inconsistent Revise state.

@willtebbutt
Copy link
Member

Ooo before I merge, could you please bump the version number in the Project.toml to 0.4.6 so that I can tag a release?

@willtebbutt
Copy link
Member

Thanks for bumping the version. I'm going to merge + tag despite the test failures, because AD problems need to be addressed elsewhere.

@willtebbutt willtebbutt merged commit d5ef8a9 into JuliaGaussianProcesses:master Apr 3, 2024
2 of 6 checks passed
@willtebbutt
Copy link
Member

Thanks for the contribution @samanklesaria

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants