Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reland "Generalize broadcast!(f, ::BitVector) optimization to BitArray." (#52736) #52776

Merged
merged 2 commits into from
Jan 7, 2024

Conversation

N5N3
Copy link
Member

@N5N3 N5N3 commented Jan 6, 2024

It turns out there're some indexing bug for CartesianIndex in our ecosystem.
#52775 (comment)

The second commit tries to "fix" it by replacing CartesianIndex{1} with Integer for broadcast indexing.

@N5N3 N5N3 added the re-land This relands a PR that was previously merged but was later reverted. label Jan 6, 2024
@maleadt
Copy link
Member

maleadt commented Jan 6, 2024

Thanks!

@nanosoldier runtests()

@nanosoldier
Copy link
Collaborator

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

@N5N3 N5N3 merged commit 8fe383f into JuliaLang:master Jan 7, 2024
4 of 7 checks passed
@N5N3 N5N3 deleted the reland branch January 7, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
re-land This relands a PR that was previously merged but was later reverted.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants