Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove debug @shows in tests #52983

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Remove debug @shows in tests #52983

merged 1 commit into from
Jan 20, 2024

Conversation

giordano
Copy link
Contributor

@DilumAluthge
Copy link
Member

Could we convert these to test contexts (the feature that @Keno added)? So then they get hidden if the tests pass, but they get printed if the tests fail.

@giordano
Copy link
Contributor Author

Could we convert these to test contexts

I don't see how, as they are in the source code of packages compiled in a subprocess, they aren't variables in the same scope as the tests.

@KristofferC KristofferC merged commit 6246074 into master Jan 20, 2024
5 of 7 checks passed
@KristofferC KristofferC deleted the giordano-patch-1 branch January 20, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giordano @DilumAluthge @KristofferC