Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[finufft] Update FINUFFT source to v2.3.0 #9406

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

ludvigak
Copy link
Contributor

No description provided.

@ludvigak ludvigak marked this pull request as draft September 10, 2024 09:11
@jkrimmer
Copy link
Contributor

Hi Ludvig,

I have already been working on updating the build_tarballs.jl for v2.3.0. Unfortunately, xsimd is incompatible with the armv6 and powerpc plattforms at the moment (see also https://xsimd.readthedocs.io/en/latest/index.html#introduction). Further, building for armv7 does not seem to work either. For unsupported platforms, some required function definitions are missing which is probably related to xtensor-stack/xsimd#954. Hence, I applied the following modification to build_tarballs.jl:

abstract_platforms = filter!(p -> !(contains(arch(p), "armv") || contains(arch(p), "powerpc")), supported_platforms())
platforms = expand_cxxstring_abis(expand_microarchitectures(abstract_platforms, ["x86_64", "avx", "avx2", "avx512"]); skip=!Sys.iswindows)

@ludvigak
Copy link
Contributor Author

Thanks for the patch, I'll add it to the PR!

@DiamonDinoia
Copy link

Hi Ludvig,

I have already been working on updating the build_tarballs.jl for v2.3.0. Unfortunately, xsimd is incompatible with the armv6 and powerpc plattforms at the moment (see also xsimd.readthedocs.io/en/latest/index.html#introduction). Further, building for armv7 does not seem to work either. For unsupported platforms, some required function definitions are missing which is probably related to xtensor-stack/xsimd#954. Hence, I applied the following modification to build_tarballs.jl:

abstract_platforms = filter!(p -> !(contains(arch(p), "armv") || contains(arch(p), "powerpc")), supported_platforms())
platforms = expand_cxxstring_abis(expand_microarchitectures(abstract_platforms, ["x86_64", "avx", "avx2", "avx512"]); skip=!Sys.iswindows)

Can't we build the old version for older platforms? Support will be re-added in the future as we plan on making xsimd optional.

@ludvigak
Copy link
Contributor Author

Can't we build the old version for older platforms? Support will be re-added in the future as we plan on making xsimd optional.

I think we could get away with just requiring that finufft_jll should be v2.2.0 or higher, since that should load the highest version for which there is a compatible binary

@ludvigak ludvigak marked this pull request as ready for review September 10, 2024 14:59
@giordano giordano merged commit 657be9c into JuliaPackaging:master Sep 11, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants