Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: JavisNB v0.1.0 #52850

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Jan 20, 2022

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2022

Your new package pull request does not meet the guidelines for auto-merging. Please make sure that you have read the General registry README and the AutoMerge guidelines. The following guidelines were not met:

  • Package name similar to 1 existing package.
    1. Similar to Javis. Damerau-Levenshtein distance 2 is at or below cutoff of 2.

Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human.

After you have fixed the AutoMerge issues, simple retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your Project.toml file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number).

If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged.

Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@JuliaRegistrator JuliaRegistrator force-pushed the registrator/javisnb/92afb270/v0.1.0 branch from 11b99c1 to fd62567 Compare January 20, 2022 15:35
@JuliaRegistrator JuliaRegistrator temporarily deployed to stopwatch January 20, 2022 15:35 Inactive
@gpucce
Copy link

gpucce commented Jan 20, 2022

Hi,

The reason JavisNB can't be installed or loaded is that it depends on a version of Javis that is yet to be released. This is the case because most the functionality of JavisNB are exported from Javis itself and it will be the package holding all the notebooks functionalities. However, doing this required some changes in Javis that will be available in the next release, the one JavisNB depends on.

That said, we though it was not the case to relax the compat because otherwise there would be a downloadable release of JavisNB that does not work. At the same time if we release Javis 0.8 right now there would be no way to use it within a notebook until JavisNB is itself released.

What is the best way to go?

Thanks you in advance!

Taggin others for reference
@Wikunia

@giordano
Copy link
Member

Registering a package which depends on an unregistered version makes the registry inconsistent. That's not something we want to do

@Wikunia
Copy link
Contributor

Wikunia commented Jan 20, 2022

Okay then I would suggest we Release v0.8 of Javis and would be great if we would not need to wait 3days for this to be released such that they can immediately work together.
I'm totally fine with waiting three days now though and then release Javis v0.8.

UUID: 92afb270-2599-44f6-96a1-44c6efb1daf1
Repo: https://github.com/JuliaAnimators/JavisNB.jl.git
Tree: 48746b8dcc0f7853de8b36829f734780ffd79ab6

Registrator tree SHA: 8e1a5ac2695627143951512d700c7e3c445102ec
@JuliaRegistrator JuliaRegistrator force-pushed the registrator/javisnb/92afb270/v0.1.0 branch from fd62567 to 3292110 Compare February 1, 2022 21:51
@JuliaRegistrator JuliaRegistrator temporarily deployed to stopwatch February 1, 2022 21:51 Inactive
@Wikunia
Copy link
Contributor

Wikunia commented Feb 1, 2022

Would be great if this could be merged soon such that Javis users can use notebooks with the latest Javis version. Thanks in advance. Let us (@gpucce and me) know if there is anything else we should do. Thanks in advance!

@giordano giordano merged commit 983e2b2 into master Feb 1, 2022
@giordano giordano deleted the registrator/javisnb/92afb270/v0.1.0 branch February 1, 2022 22:10
@Wikunia
Copy link
Contributor

Wikunia commented Feb 2, 2022

Thank you ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants