Edit the pca_weights_init function to fix eigenvectors #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for raising this PR, the ci is failing because of an indentation issue and there the units tests haven't been adjusted. Are you happy to make the necessary changes? |
Fix indentation issue in pca_init
Update test_pca_weights_init. Redefine expected array.
|
My apologies! I believe I fixed the indentation issue and I updated the "expected" array under "test_pca_weights_init()" in the unit test section. Are any other changes required for the unit tests? Please let me know if there are any other issues. |
|
Unfortunate unit tests are still failing. Please check the output of the CI. |
JustGlowing
added
duplicate
and removed
to-be-merged
|
closing as the change has been implemented somewhere else |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify line that calculates eigenvectors. Add line to calculate principal components. Modify line to calculate initial weights using the first two principal components.