Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I already created pip package that fulfills the functionality I aimed to achieve with this PR. I just thought it would be more convenient if this was integrated directly into the main package.
This implementation depends on Scikit-learn and SciPy. Given their widespread use and the fact that most DS and ML setups (e.g., Anaconda) include these dependencies by default, I believe this should not be a significant issue. Algorithm under the hood is still Yours lightweight implementation.
I know that You aimed for as little bloat as possible so if that's an issue, my package is there to fill the gap.
Key changes:
Pipeline
andGridSearchCV
(and probably other similar estimators).pycodestyle
andpytest
are run—check out the README for the details.Also, I named the main class in my package MiniSOM beacause I think that capitalized "SOM" makes more sense.