Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sklearn wrapper #197

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

koloiyolo
Copy link

I already created pip package that fulfills the functionality I aimed to achieve with this PR. I just thought it would be more convenient if this was integrated directly into the main package.

This implementation depends on Scikit-learn and SciPy. Given their widespread use and the fact that most DS and ML setups (e.g., Anaconda) include these dependencies by default, I believe this should not be a significant issue. Algorithm under the hood is still Yours lightweight implementation.

I know that You aimed for as little bloat as possible so if that's an issue, my package is there to fill the gap.

Key changes:

  • tweak the file structure to make imports more intuitive. As demonstrated here, it shouldn't break any compatibility.
  • add an easy-to-use API that feels familiar to Scikit-learn users, making it simpler for developers and researchers to work with.
  • add support for Scikit-learn Pipeline and GridSearchCV(and probably other similar estimators).
  • put the unit tests into their own file to keep things organized.
  • changed how pycodestyle and pytest are run—check out the README for the details.

Also, I named the main class in my package MiniSOM beacause I think that capitalized "SOM" makes more sense.

@JustGlowing
Copy link
Owner

hi @koloiyolo, thanks for submitting this work. I'll have a look as soon as I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants