Issue#17 #18
Open
Issue#17 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 6, 2019 18:02
Varunvaruns9
requested changes
Jul 6, 2019
carpool/views.py
Outdated
| if request.user.is_authenticated: | ||
| return HttpResponseRedirect('/') | ||
| if request.method == 'POST': | ||
| elif request.method == 'POST': |
There was a problem hiding this comment.
elif is not required here as the first if has a return at its end.
| # email = EmailMessage(mail_subject, message, to=[to_email]) | ||
| # email.send() | ||
| else: | ||
| form = SignUpForm() | ||
| return render(request, 'signup.html', {'form': form, 'error': error, 'done': done, }) |
There was a problem hiding this comment.
It is better to have a combined render rather than using the same code three times, just remove the done variable.
carpool/views.py
Outdated
| @@ -47,12 +48,15 @@ def new(request): | |||
| }) | |||
| to_email = form.cleaned_data.get('email') | |||
| send_mail(mail_subject, message, '[email protected]', [to_email], fail_silently=False) | |||
| done=True | |||
| HttpResponseRedirect("{% url 'polls.signupcomp' %}") | |||
There was a problem hiding this comment.
Add a return before the function. Also, this URL syntax doesn't work. Use HttpResponseRedirect("/signupcomp/") instead.
|
@dipanshu231099 Are you still working on this? Please do better PR names from now on. Putting an issue number in you PR name is not good. |
next time onwards will take care of that @vsvipul |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the present pr will open a new page to show the user a page where he will be told to go to his email address for the conformation link. However in my app addition of a new user is not working and it is always showing the error for
elif not form.is_valid