Handle updates through merged chapters #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 30, 2024 21:26
For example: ch2 1.zip ch2 2.zip Kavita will merge these into one big ch2. Recognize and handle chapter merges.
ThePromidius
approved these changes
Oct 31, 2024
Comment on lines
515
to
+518
| override fun pageListRequest(chapter: SChapter): Request { | ||
| return GET("$apiUrl/${chapter.url}", headersBuilder().build()) | ||
| // remove potential _<part> chapter salt | ||
| val chapterId = chapter.url.substringBefore("_") | ||
| return GET("$apiUrl/$chapterId", headersBuilder().build()) |
There was a problem hiding this comment.
@majora2007 we sure there won't ever be other underscores apart from the salt one we add, right? Otherwise seems fine.
There was a problem hiding this comment.
What does the url map to? A special can technically have _ in the name.
There was a problem hiding this comment.
url is defined as url = chapter.id.toString().
There was a problem hiding this comment.
So maybe I missed it, how is the underscore being sent?
There was a problem hiding this comment.
It’s not, I’m adding it locally.
<chapterId>_<numberOfFiles>
As ThePromidius points out, this approach would fail if the id somehow already contains an underscore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a chapter gets new content server side through chapter merges, not only does the extension not notify the user of this update, but as long as the old data still resides in the cache, it’s straight up impossible to access the new chapter part.
This fix assumes the only way a chapter would have multiple files is through part merges.
Unless multiple files are reported, nothing is changed, so this should be fairly backwards compatible too.
See also:
Kareadita/Kavita#3272
Checklist:
extVersionCodevalue inbuild.gradlefor individual extensionsoverrideVersionCodeorbaseVersionCodeas needed for all multisrc extensionsisNsfw = trueflag inbuild.gradlewhen appropriateidif a source's name or language were changed