Skip to content

Commit

Permalink
Adds CONTRIBUTING.md (#295)
Browse files Browse the repository at this point in the history
* Adds email address to CODE_OF_CONDUCT.md

* Adds CONTRIBUTING.md

* Removes clang-format text from README.md

* Fixes typo in CONTRIBUTING.md file link.
  • Loading branch information
Kenix3 authored May 29, 2023
1 parent 19dce80 commit 31189cc
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 7 deletions.
2 changes: 1 addition & 1 deletion CODE_OF_CONDUCT.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ representative at an online or offline event.

Instances of abusive, harassing, or otherwise unacceptable behavior may be
reported to the community leaders responsible for enforcement at
[INSERT CONTACT METHOD].
[email protected].
All complaints will be reviewed and investigated promptly and fairly.

All community leaders are obligated to respect the privacy and security of the
Expand Down
19 changes: 19 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# Preface
LUS accepts any and all contributions. You can interact with the project via PRs, issues, email ([email protected]), or [Discord](https://discord.gg/RQvdvavB).

# Code of Conduct
Please review and abide by our [code of conduct](https://github.com/Kenix3/libultraship/blob/main/CODE_OF_CONDUCT.md).

# Building
Please see the [readme](https://github.com/Kenix3/libultraship/blob/main/README.md) for building instructions.

# Pull Requests
## Procedures
Our CI system will automatically check your PR to ensure that it fits [formatting guidelines](https://github.com/Kenix3/libultraship/blob/main/.clang-format), [linter guidelines](https://github.com/Kenix3/libultraship/blob/main/.clang-tidy), and that the code builds. The submitter of a PR is required to ensure their PR passes all CI checks. The submitter of the PR is encouraged to address all PR review comments in a timely manner to ensure a timely merge of the PR.
### Troubleshooting CI Errors
#### tidy-format-validation
If the tidy-format-validation check fails, then you need to run clang-format. Below is a command that can be used on Linux. Most modern IDEs have a clang-format plugin that can be used. The [.clang-format file can be found here](https://github.com/Kenix3/libultraship/blob/main/.clang-format)
##### Running clang-format
```
find src include -name "*.cpp" -o -name "*.h" | sed 's| |\\ |g' | xargs clang-format-12 -i
```
11 changes: 5 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,12 @@ libultraship (LUS) is a library meant to provide reimplementations of libultra (

LUS uses an asset loading system where data is stored separately from the executable in an archive file ending in `.otr`, which is an [`.mpq`](http://www.zezula.net/en/mpq/main.html) compatible file. This separation the data from the executable follows modern design practices and that it is more mod friendly. All one needs to do is supply a patch `.otr` and the system will automatically replace the data.

## Contributing
LUS accepts any and all contributions. You can interact with the project via PRs, issues, email ([email protected]), or [Discord](https://discord.gg/RQvdvavB).
Please see [CONTRIBUTING.md](https://github.com/Kenix3/libultraship/blob/main/CONTRIBUTING.md) file for more information.

## Versioning
We use semantic versioning. We have defined the API as `every C linkage function, variable, struct, class, public class method, or enum included from libultraship.h`.
We use semantic versioning. We have defined the API as: every C linkage function, variable, struct, class, public class method, or enum included from libultraship.h.

## Building on Linux/Mac
```
Expand All @@ -25,11 +29,6 @@ cmake --build build
& 'C:\Program Files\CMake\bin\cmake' --build .\build\x64
```

## Running clang-format
```
find src include -name "*.cpp" -o -name "*.h" | sed 's| |\\ |g' | xargs clang-format-12 -i
```

## Sponsors
Thankyou to JetBrains for providing their IDE [CLion](https://www.jetbrains.com/clion/) to me for free!

Expand Down

0 comments on commit 31189cc

Please sign in to comment.