buffered wheel axis mapping (test)

Kenix3 · Jan 2, 2025 · e703d9c · e703d9c
1 parent e98eb3c
commit e703d9c
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 12 deletions.
diff --git a/src/controller/controldevice/controller/mapping/mouse/MouseWheelToAxisDirectionMapping.cpp b/src/controller/controldevice/controller/mapping/mouse/MouseWheelToAxisDirectionMapping.cpp
@@ -19,9 +19,7 @@ float MouseWheelToAxisDirectionMapping::GetNormalizedAxisDirectionValue() {
         return 0.0f;
     }
 
-    // TODO: scale input to match with MAX_AXIS_RANGE
-    // note: this is temporary solution to test numbers on different backends
-    return fmin(WheelHandler::GetInstance()->GetDirectionValue(mWheelDirection) * MAX_AXIS_RANGE, MAX_AXIS_RANGE);
+    return fmin(WheelHandler::GetInstance()->GetBufferedDirectionValue(mWheelDirection), 1.0f) * MAX_AXIS_RANGE;
 }
 
 std::string MouseWheelToAxisDirectionMapping::GetAxisDirectionMappingId() {

diff --git a/src/controller/controldevice/controller/mapping/mouse/WheelHandler.cpp b/src/controller/controldevice/controller/mapping/mouse/WheelHandler.cpp
@@ -1,5 +1,6 @@
 #include "WheelHandler.h"
 #include "Context.h"
+#include <cmath>
 
 namespace Ship {
 WheelHandler::WheelHandler() {
@@ -18,9 +19,24 @@ std::shared_ptr<WheelHandler> WheelHandler::GetInstance() {
     return mInstance;
 }
 
+void ApplyToBuffer(float* dst, float src) {
+    if (fabs(src) == 0) {
+        return;
+    }
+    *dst = fmin(2.0f, *dst + src);
+}
+
 void WheelHandler::Update() {
     mCoords = Context::GetInstance()->GetWindow()->GetMouseWheel();
 
+    // reduce buffered value
+    ApplyToBuffer(&mBufferedCoords.x, -copysignf(1, mBufferedCoords.x));
+    ApplyToBuffer(&mBufferedCoords.y, -copysignf(1, mBufferedCoords.y));
+
+    // add new value to buffer
+    ApplyToBuffer(&mBufferedCoords.x, mCoords.x);
+    ApplyToBuffer(&mBufferedCoords.y, mCoords.y);
+
     mDirections.x = mDirections.y = LUS_WHEEL_NONE;
     if (mCoords.x < 0) {
         mDirections.x = LUS_WHEEL_LEFT;
@@ -42,28 +58,36 @@ WheelDirections WheelHandler::GetDirections() {
     return mDirections;
 }
 
-float WheelHandler::GetDirectionValue(WheelDirection direction) {
+float CalcDirectionValue(CoordsF& coords, WheelDirection direction) {
     switch (direction) {
         case LUS_WHEEL_LEFT:
-            if (mCoords.x < 0) {
-                return -mCoords.x;
+            if (coords.x < 0) {
+                return -coords.x;
             }
             break;
         case LUS_WHEEL_RIGHT:
-            if (mCoords.x > 0) {
-                return mCoords.x;
+            if (coords.x > 0) {
+                return coords.x;
             }
             break;
         case LUS_WHEEL_DOWN:
-            if (mCoords.y < 0) {
-                return -mCoords.y;
+            if (coords.y < 0) {
+                return -coords.y;
             }
             break;
         case LUS_WHEEL_UP:
-            if (mCoords.y > 0) {
-                return mCoords.y;
+            if (coords.y > 0) {
+                return coords.y;
             }
     }
     return 0.0f;
 }
+
+float WheelHandler::GetDirectionValue(WheelDirection direction) {
+    return CalcDirectionValue(mCoords, direction);
+}
+
+float WheelHandler::GetBufferedDirectionValue(WheelDirection direction) {
+    return CalcDirectionValue(mBufferedCoords, direction);
+}
 } // namespace Ship
diff --git a/src/controller/controldevice/controller/mapping/mouse/WheelHandler.h b/src/controller/controldevice/controller/mapping/mouse/WheelHandler.h
@@ -21,11 +21,13 @@ class WheelHandler {
     CoordsF GetCoords();
     WheelDirections GetDirections();
     float GetDirectionValue(WheelDirection direction);
+    float GetBufferedDirectionValue(WheelDirection direction);
 
   private:
     static std::shared_ptr<WheelHandler> mInstance;
 
     WheelDirections mDirections;
     CoordsF mCoords;
+    CoordsF mBufferedCoords;
 };
 } // namespace Ship