this is a stupid hack... #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kenix3
added a commit
that referenced
this pull request
Feb 8, 2024
* Removes Pulse Audio. Config values will be migrated to sdl audio backend. #311 * Removes PulseAudio.h from classes.h * Refactors archives to have a separate manager class. * Run clang-format * Includes string in ResourceType.h * Only include tchar.h in Context.cpp when building for Windows. * Includes vector in ArchiveManager.h * fix: put `SDL_WndProc` behind `_WIN32` ifdef (#423) * Fix issues with Archive refactor (#424) * get in game * clang format * windows build * pr comments * return false * uncomment * fix fonts * pr comment * init dadon't * raw * Fixes issue where ArchiveManager never unloads Archives. * Fixes builds for StormLib issues. (#425) * this is a stupid hack but i'm too tired to keep trying to figure out how we're linking everything * link? * ports... * windows? --------- Co-authored-by: briaguya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
but i'm too tired to keep trying to figure out how we're linking everything
before adding this (such as here https://github.com/HarbourMasters/Shipwright/actions/runs/7810272355/job/21303458931)
SFileCreateArchivewas just not getting linked.this is definitely not how i want to fix this. i think it's possible to use
--whole-archivebut i'm not sure where that fits into the whole cmake chain.the strangest part is that there were no linker errors when just building
OTRExporterfor theExtractAssetstarget