Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ios support #491

Merged
merged 26 commits into from
Apr 28, 2024
Merged

Added ios support #491

merged 26 commits into from
Apr 28, 2024

Conversation

KiritoDv
Copy link
Contributor

@KiritoDv KiritoDv commented Apr 19, 2024 •
edited
Loading

This PR adds simple IOS support, it should not break any other platform since everything is wrapped on PLATFORM_IOS

briaguya-ai
briaguya-ai reviewed Apr 19, 2024
View reviewed changes
Copy link
Collaborator

@briaguya-ai briaguya-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall the stuff that seems similar to the android stuff seems reasonable, there are a few things in here that feel like they're better off living on the port side than the LUS side though

extern/CMakeLists.txt Outdated Show resolved Hide resolved
extern/CMakeLists.txt Outdated Show resolved Hide resolved
ios/Icon.png Outdated Show resolved Hide resolved
ios/Launch.storyboard Outdated Show resolved Hide resolved
ios/plist.in Outdated Show resolved Hide resolved
src/resource/archive/ArchiveManager.cpp Outdated Show resolved Hide resolved
src/window/Window.cpp Outdated Show resolved Hide resolved
src/window/Window.cpp Show resolved Hide resolved
src/window/gui/Gui.cpp Show resolved Hide resolved
src/window/gui/Gui.cpp Show resolved Hide resolved
briaguya-ai
briaguya-ai reviewed Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@briaguya-ai briaguya-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly small things, anything bigger i've noted as something that'd be nice to make an issue for and out of scope for this pr

cmake/ios.toolchain.cmake Outdated Show resolved Hide resolved
cmake/dependencies/ios.cmake Outdated Show resolved Hide resolved
cmake/dependencies/ios.cmake Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
src/resource/archive/O2rArchive.cpp Outdated Show resolved Hide resolved
src/resource/archive/O2rArchive.h Outdated Show resolved Hide resolved
src/window/Window.cpp Show resolved Hide resolved
src/window/gui/Gui.cpp Outdated Show resolved Hide resolved
src/window/gui/Gui.cpp Outdated Show resolved Hide resolved
This was referenced Apr 26, 2024
Closed
Open
briaguya-ai
briaguya-ai approved these changes Apr 26, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
extern/CMakeLists.txt Show resolved Hide resolved
src/CMakeLists.txt Show resolved Hide resolved
src/graphic/Fast3D/gfx_metal.cpp Show resolved Hide resolved
src/window/Window.cpp Show resolved Hide resolved
@briaguya-ai
Copy link
Collaborator

verified by HarbourMasters/Shipwright#4076

@briaguya-ai briaguya-ai merged commit a245aaf into Kenix3:main Apr 28, 2024
5 checks passed
@KiritoDv KiritoDv deleted the ios-support branch April 28, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briaguya-ai briaguya-ai briaguya-ai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KiritoDv @briaguya-ai