Implemented dither noise #492
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archez
reviewed
Apr 19, 2024
Archez
reviewed
Apr 19, 2024
Archez
reviewed
Apr 19, 2024
Archez
reviewed
Apr 19, 2024
src/graphic/Fast3D/gfx_pc.cpp
Outdated
| @@ -3886,7 +3898,7 @@ void gfx_run(Gfx* commands, const std::unordered_map<Mtx*, MtxF>& mtx_replacemen | |||
| !game_renders_to_framebuffer); | |||
| gfx_rapi->start_frame(); | |||
| gfx_rapi->start_draw_to_framebuffer(game_renders_to_framebuffer ? game_framebuffer : 0, | |||
| (float)gfx_current_dimensions.height / gfx_native_dimensions.height); | |||
| gfx_calculate_noise_scale(), g_rdp.alpha_test_value); | |||
There was a problem hiding this comment.
Passing in alpha_test_value through start_draw_to_framebuffer means that the value is only read and set once at the very beginning of the frame.
But you implemented gfx_dp_set_blend_color which influences this value, but it'll never be updated to the shader this way.
Comment on lines
583
to
591
| if (cc_features.opt_alpha && cc_features.opt_noise) { | ||
| append_line( | ||
| fs_buf, &fs_len, | ||
| "texel.a = alphaDither(random(vec3(floor(gl_FragCoord.xy * noise_scale), float(frame_count))), texel.a);"); | ||
| } else if (cc_features.opt_noise) { | ||
| append_line(fs_buf, &fs_len, | ||
| "texel.a *= floor(clamp(random(vec3(floor(gl_FragCoord.xy * noise_scale), float(frame_count))) + " | ||
| "texel.a, 0.0, 1.0));"); | ||
| "texel.rgb = colorDither(random(vec3(floor(gl_FragCoord.xy * noise_scale), float(frame_count))), " | ||
| "texel.rgb);"); | ||
| } |
There was a problem hiding this comment.
At least from what I can see in MM, it is possible for aplha dithering and color dithering to be applied at the same time. This if / if else does not allow that currently.
We may even need to split opt_noise into two values, or something so that we can control which is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 7321c1a)