ResourceFilter, Directory Function Renames, Multifilter Functionality #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tiple include and exclude filters in one pass. Also adds associated Load, LoadAsync, and Unload directory functions.
Change `LoadDirectory`, `UnloadDirectory`, and `DirtyDirectory` to `LoadResources`, etc. Move all Directory processing to the thread pool, encapsulating `ListFiles` as well. Unify `ListFiles` flows to eventually pass `ResourceFilter` to the base function.
Malkierian
changed the title
Kenix3
reviewed
Dec 17, 2024
Change the blank `ListFiles()` function to pass empty lists instead of "*" to allow it to trip the early list insertion and return short circuit based on them being empty.
briaguya-ai
reviewed
Dec 17, 2024
…he other one. Add handling to not add `""` to the list before passing to the base function.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a new struct,
ResourceFilter, which holds include and exclude lists as well as owner and parent options to be passed toLoadResourceas part of theResourceIdentifier. It also renames and fleshes out all Directory commands to be named with Resources instead, and threads all Resources functionality to also encapsulateListFilescalls, which addresses #736.ListFilescalls are unified now, eventually passing a ResourceFilter to the base function.