Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change coinType for agoric from 564 to 118 #633

Open
wants to merge 1 commit into
base: release/v1.3.2
Choose a base branch
from

Conversation

LuqiPan
Copy link

@LuqiPan LuqiPan commented Mar 18, 2024

Explanation

First of all, thank you for supporting Agoric chain on Keystone.

When I started using my keystone device, I noticed that the address for Agoric chain on my Keystone 3 Pro is different from the address on my Ledger Nano X, even though they share the same seed phrases.

Upon some digging, it seems like in this situation the coinType should be 118 instead of 564. Here are some relevant comments I found:

My rough understanding is that 564 is a coin type we registered, but it's necessary to use 118, the default cosmos coinType, in certain interop situations; in particular, when using a ledger.

From: Agoric/agoric-sdk#5830 (reply in thread)

PS: let me know if there are other places where I should update the coinType

Pre-merge check list

  • PR run build successfully on local machine.
  • All unit tests passed locally.

Remark: could you point me to some documentations on how to run tests on a Mac with Apple Silicon?

How to test

Not sure what's the best way to test this. I'm also not sure if the keystone device would cache the address generated with cointype 564 somewhere?

@soralit
Copy link
Contributor

soralit commented Mar 25, 2024

Hi @LuqiPan thanks for contributing. But this will affect existing users' devices, we'd consider it more seriously to do the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants