feat: change coinType for agoric from 564 to 118 #633
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
First of all, thank you for supporting Agoric chain on Keystone.
When I started using my keystone device, I noticed that the address for Agoric chain on my Keystone 3 Pro is different from the address on my Ledger Nano X, even though they share the same seed phrases.
Upon some digging, it seems like in this situation the coinType should be 118 instead of 564. Here are some relevant comments I found:
From: Agoric/agoric-sdk#5830 (reply in thread)
PS: let me know if there are other places where I should update the coinType
Pre-merge check list
Remark: could you point me to some documentations on how to run tests on a Mac with Apple Silicon?
How to test
Not sure what's the best way to test this. I'm also not sure if the keystone device would cache the address generated with cointype 564 somewhere?