Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix eth transaction parse error #67

Merged
merged 1 commit into from
Sep 19, 2023
Merged

fix eth transaction parse error #67

merged 1 commit into from
Sep 19, 2023

Conversation

soralit
Copy link
Contributor

@soralit soralit commented Sep 19, 2023

Explanation

Fix eth transaction parse error when input path is ledger live

Changes

changed the transaction parse logic of eth transaction and message

Pre-merge check list

  • PR run build successfully on local machine.
  • All unit tests passed locally.

How to test

test eth transaction and message parse

@soralit soralit changed the title Sora/bug fix fix eth transaction parse error Sep 19, 2023
@soralit soralit changed the base branch from master to release/v1.0.0 September 19, 2023 07:02
@NanYeZhuYu NanYeZhuYu merged commit d0973bf into release/v1.0.0 Sep 19, 2023
2 checks passed
@NanYeZhuYu NanYeZhuYu deleted the sora/bug-fix branch September 19, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NanYeZhuYu NanYeZhuYu NanYeZhuYu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soralit @NanYeZhuYu