Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cosmos dym vote signing #922

Merged
merged 3 commits into from
Apr 23, 2024
Merged

fix cosmos dym vote signing #922

merged 3 commits into from
Apr 23, 2024

Conversation

ZhenQian-keystone
Copy link
Contributor

@ZhenQian-keystone ZhenQian-keystone commented Apr 23, 2024 •
edited
Loading

Explanation

fix cosmos dym vote signing

Pre-merge check list

  • PR run build successfully on local machine.
  • All unit tests passed locally.

@soralit
Copy link
Contributor

soralit commented Apr 23, 2024

Add a unit test about this function.

@soralit soralit merged commit 6a07ae1 into master Apr 23, 2024
2 of 3 checks passed
@soralit soralit deleted the fix/cosmos_dym_vote_signing branch April 23, 2024 06:03
@ZhenQian-keystone ZhenQian-keystone restored the fix/cosmos_dym_vote_signing branch April 23, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soralit soralit soralit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZhenQian-keystone @soralit