fix(plugin test): close connection in plugin test environment #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zryanl
commented
Aug 19, 2024
zryanl
commented
- Addresses a connection leak in the internal plugin test environment's network connection instantiation
- Implements some extra error handling and checks in the plugin test package
|
|
|
|
- Addresses a connection leak in the internal plugin test environment's network connection instantiation
gszr
reviewed
Nov 22, 2024
| @@ -20,7 +20,7 @@ func readPbFrame(conn net.Conn) (data []byte, err error) { | |||
| var len uint32 | |||
| err = binary.Read(conn, binary.LittleEndian, &len) | |||
| if err != nil { | |||
| return | |||
| return nil, err | |||
There was a problem hiding this comment.
Note that these and others below make use of named return values, so these changes have no effect.
gszr
requested changes
Nov 22, 2024
| @@ -122,19 +122,23 @@ func (req *Request) Validate() error { | |||
| } | |||
| return nil | |||
| } | |||
| return fmt.Errorf("Unsupported method \"%v\"", req.Method) | |||
There was a problem hiding this comment.
Let's not change this error message.
| } | ||
| portnum, _ := strconv.Atoi(p) | ||
| return int32(portnum) | ||
| portnum, err := strconv.ParseInt(p, 10, 32) |
There was a problem hiding this comment.
The port is already validated in the URL object creation, so this should be unreachable.
| } | ||
|
|
||
| // New creates a new test environment. | ||
| func New(t *testing.T, req Request) (env *TestEnv, err error) { | ||
| err = req.Validate() | ||
| if err != nil { | ||
| return | ||
| return nil, err |
There was a problem hiding this comment.
Named return value. Let's not change this and others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.