Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(clustering/sync): avoiding long delay caused by race condition #13896

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(clustering/sync): avoiding long delay caused by race condition #13896

wants to merge 2 commits into from
+42 −18

Conversation

StarlightIbuki
Copy link
Contributor

@StarlightIbuki StarlightIbuki commented Nov 20, 2024 •
edited by chobits
Loading

Summary

It will retry until the version matches

Checklist

  • The Pull Request has tests
  • A changelog file has been added to CHANGELOG/unreleased/kong or adding skip-changelog label on PR if unnecessary. README.md
  • The Pull Request has backports to all the versions it needs to cover
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix KAG-5857 KAG-5876

@github-actions github-actions bot added core/clustering cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Nov 20, 2024
@StarlightIbuki StarlightIbuki requested review from dndx, chronolaw and chobits and removed request for dndx November 20, 2024 08:56
@chronolaw chronolaw changed the title fix(sync): avoiding long delay caused by race condition fix(clustering/sync): avoiding long delay caused by race condition Nov 20, 2024
@chronolaw
Copy link
Contributor

Could we write a test case to verify this fix?

@StarlightIbuki
Copy link
Contributor Author

Could we write a test case to verify this fix?

Not easily. We cannot be sure that the race conditions happen when we test. We could observe whether it relieves the flaky tests.

chronolaw
chronolaw approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@chronolaw chronolaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should work, refactoring or cleaning may be later.

@StarlightIbuki
Copy link
Contributor Author

Please merge this after release, as this is not a blocker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chronolaw chronolaw chronolaw approved these changes

@chobits chobits chobits approved these changes

@dndx dndx Awaiting requested review from dndx

Assignees

@StarlightIbuki StarlightIbuki

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/clustering size/M skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@StarlightIbuki @chronolaw @chobits @dndx