Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dao): page size 1 does not work for lmdb #13908

Merged
merged 1 commit into from
Nov 22, 2024
Merged

fix(dao): page size 1 does not work for lmdb #13908

merged 1 commit into from
Nov 22, 2024

Conversation

StarlightIbuki
Copy link
Contributor

Summary

We can simply drop the extra result.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • [N/A] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix KAG-5875

@github-actions github-actions bot added core/db cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Nov 21, 2024
@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 21, 2024
@pull-request-size pull-request-size bot added size/S and removed size/M labels Nov 21, 2024
@chronolaw
Copy link
Contributor

need a version bump change log.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 22, 2024
@StarlightIbuki StarlightIbuki force-pushed the fix/lmdb-page-size-1 branch 4 times, most recently from 88ec1ed to e0bef1e Compare November 22, 2024 04:29
@dndx dndx requested a review from chronolaw November 22, 2024 05:43
@dndx dndx merged commit c924a23 into master Nov 22, 2024
26 checks passed
@dndx dndx deleted the fix/lmdb-page-size-1 branch November 22, 2024 06:55
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

ProBrian pushed a commit that referenced this pull request Dec 13, 2024
@StarlightIbuki @ProBrian
fix(dao): page size 1 now works correctly for DB-less (#13908)
d020b5e 
KAG-5875
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gszr gszr gszr left review comments

@chobits chobits chobits approved these changes

@dndx dndx dndx approved these changes

@chronolaw chronolaw Awaiting requested review from chronolaw

Assignees

@StarlightIbuki StarlightIbuki

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/db size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@StarlightIbuki @chronolaw @team-gateway-bot @chobits @dndx @gszr