-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace kennethreitz/httpbin with arm64 enabled arnaudlacour/httpbin #2548
chore: replace kennethreitz/httpbin with arm64 enabled arnaudlacour/httpbin #2548
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switching to this fork seems like a net negative for supply chain security.
I want to suggest we consider doing one of the following:
- trying to engage with postmanlabs and see if they would accept new PRs to port the ARM64 builds into httpbin (it's been years, so they might not)
- do our own
kong
fork of httpbin so that we're controlling the upstream
Let me know your thoughts?
ca07bad
to
d398270
Compare
postmanlabs have not updated httpbin repo since 4 years. There is plenty of issues without any response. The image that we used so far |
That's true but the idea behind this PR was to make the tests run on arm64. The fork that I proposed didn't even have a single commit more than what the original repo has, so there's hardly any change w.r.t functionalities and/or base image etc. The consensus around this issue was to either change the image used in tests or fork it and make appropriate changes so that it builds for arm64 and publishes the images onto e.g. the docker hub and preferably update the base image as well (as you've mentioned). Perhaps there was a mishap on my part that I didn't communicate this clearly here. |
To my understanding we're simply at a point where we want to fork, update, and thereafter maintain this and the |
Actually, let's leave this as is so that it we don't drop the ball on this. We can then add a "superseded by #...." comment in the new PR that will introduce the usage of said fork. WDYT? |
I'm fine with leaving it open as a reminder, though for review purposes I think we should switch it to draft 👍 |
You could use also https://hub.docker.com/repository/docker/svenwal/httpbin/general which is under my control (and I am a member of Kong). It runs on ARM and also does not need root privileges (exposed 8080 instead of 80). |
Thanks @svenwal but I think @mlavacca is already pretty close to the final result: https://github.com/Kong/httpbin with multi arch images already being pushed to https://hub.docker.com/r/kong/httpbin/tags |
Don't miss the chance to also deploy as non-root (like secure K8s and OpenShift env need it) |
Yup, good idea. cc: @mlavacca |
I agree this can be a good idea. I'm running the test with the |
Superseded by #2596 |
What this PR does / why we need it:
NOTE: This supersedes #2547 in the sense that this replace all the occurrences of
kennethreitz/httpbin
intoarnaudlacour/httpbin
not only those in tests.This PR address the fact that as of now we're using
kennethreitz/httpbin
which provides onlylinux/amd64
.Since the github repo that hosts code for that image seems to be unmaintained, and since there is an issue that raises the lack of arm64 support let's use a repo that hosts images for a fork of the original one.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:kind
cluster on an arm64 Mac M1