Classic Era Support: Ease Dependency on Cell's LibGroupInfo #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make Lib load silent - Check for lib table before accessing it
|
Not sure about the power filter Cell has for classic, but not really relevant to the goal of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on getting the addon functional in Classic Era for the upcoming anniversary servers.
Cell does not load
LibGroupInfoin theLoadLibs_Classic.xmlany more, which is used in itsCell_Vanilla.toc.Since the dependency on LGI is pretty minor I was hoping this was an acceptable solution. ƪ(˘⌣˘)ʃ