[Feature]: Hide Classbar Out of Combat #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krealle
requested changes
Nov 19, 2024
|
Thanks for the feedback, the issues should be addressed now. I also fixed an issue with the visibility of the bar not being updated when changing the setting, I'm not sure if my approach is correct though - let me know. |
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new checkbox option to the player class bar that enables automatic hiding based on combat state.
classbar-toggle-combat.mp4
I've done my best to follow the code style of existing widgets. Let me know if there's more to be done (localization etc.)