change magic number range to const surely we get more range soon copium

Krealle · Mar 17, 2024 · 051b528 · 051b528
1 parent f5964d8
commit 051b528
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 10 deletions.
diff --git a/src/analysis/retail/evoker/devastation/modules/Abilities.tsx b/src/analysis/retail/evoker/devastation/modules/Abilities.tsx
@@ -3,6 +3,7 @@ import CoreAbilities from 'analysis/retail/evoker/shared/modules/Abilities';
 import { SpellbookAbility } from 'parser/core/modules/Ability';
 import SPELL_CATEGORY from 'parser/core/SPELL_CATEGORY';
 import SPELLS from 'common/SPELLS';
+import { BASE_EVOKER_RANGE } from '../../shared';
 
 class Abilities extends CoreAbilities {
   spellbook(): SpellbookAbility[] {
@@ -15,7 +16,7 @@ class Abilities extends CoreAbilities {
         gcd: {
           base: 1500,
         },
-        range: 25,
+        range: BASE_EVOKER_RANGE,
         enabled: combatant.hasTalent(TALENTS.PYRE_TALENT),
       },
       {
@@ -29,7 +30,7 @@ class Abilities extends CoreAbilities {
           suggestion: true,
           recommendedEfficiency: 0.9,
         },
-        range: 25,
+        range: BASE_EVOKER_RANGE,
         enabled: combatant.hasTalent(TALENTS.FIRESTORM_TALENT),
       },
       {
@@ -45,7 +46,7 @@ class Abilities extends CoreAbilities {
           suggestion: true,
           recommendedEfficiency: 0.95,
         },
-        range: 25,
+        range: BASE_EVOKER_RANGE,
         enabled: combatant.hasTalent(TALENTS.ETERNITY_SURGE_TALENT),
       },
       {
@@ -60,7 +61,7 @@ class Abilities extends CoreAbilities {
           recommendedEfficiency: 0.9,
           extraSuggestion: 'You should aim to use this off CD.',
         },
-        range: 25,
+        range: BASE_EVOKER_RANGE,
         enabled: combatant.hasTalent(TALENTS.SHATTERING_STAR_TALENT),
       },
       //endregion

diff --git a/src/analysis/retail/evoker/shared/constants.ts b/src/analysis/retail/evoker/shared/constants.ts
@@ -5,3 +5,5 @@ export const INNATE_MAGIC_REGEN = 0.05;
 export const BASE_MAX_ESSENCE = 5;
 
 export const POTENT_MANA_MULTIPLIER = 0.03;
+
+export const BASE_EVOKER_RANGE = 25;
diff --git a/src/analysis/retail/evoker/shared/modules/Abilities.tsx b/src/analysis/retail/evoker/shared/modules/Abilities.tsx
@@ -7,6 +7,7 @@ import { SpellbookAbility } from 'parser/core/modules/Ability';
 import SPELL_CATEGORY from 'parser/core/SPELL_CATEGORY';
 import spells from 'common/SPELLS/dragonflight/trinkets';
 import trinkets from 'common/ITEMS/dragonflight/trinkets';
+import { BASE_EVOKER_RANGE } from '../constants';
 
 const hasFont = (combatant: Combatant) =>
   combatant.hasTalent(TALENTS.FONT_OF_MAGIC_PRESERVATION_TALENT) ||
@@ -31,7 +32,7 @@ class Abilities extends CoreAbilities {
         gcd: {
           base: 1500,
         },
-        range: 25,
+        range: BASE_EVOKER_RANGE,
         enabled: combatant.spec !== SPECS.AUGMENTATION_EVOKER,
       },
       {
@@ -42,7 +43,7 @@ class Abilities extends CoreAbilities {
         gcd: {
           base: 1500,
         },
-        range: 25,
+        range: BASE_EVOKER_RANGE,
         damageSpellIds: [SPELLS.EMERALD_BLOSSOM_CAST.id],
         isDefensive: true,
       },
@@ -64,15 +65,15 @@ class Abilities extends CoreAbilities {
             recommendedEfficiency: 0.95,
           },
         }),
-        range: 25,
+        range: BASE_EVOKER_RANGE,
       },
       {
         spell: SPELLS.LIVING_FLAME_CAST.id,
         category: SPELL_CATEGORY.ROTATIONAL,
         gcd: {
           base: 1500,
         },
-        range: 25,
+        range: BASE_EVOKER_RANGE,
         damageSpellIds: [SPELLS.LIVING_FLAME_DAMAGE.id],
       },
       {
@@ -82,7 +83,7 @@ class Abilities extends CoreAbilities {
             ? SPELL_CATEGORY.HEALER_DAMAGING_SPELL
             : SPELL_CATEGORY.ROTATIONAL,
         cooldown: 0,
-        range: 25,
+        range: BASE_EVOKER_RANGE,
         gcd: {
           base: 1500,
         },
@@ -186,7 +187,7 @@ class Abilities extends CoreAbilities {
         gcd: {
           base: 1500,
         },
-        range: 25,
+        range: BASE_EVOKER_RANGE,
       },
       {
         spell: TALENTS.OPPRESSING_ROAR_TALENT.id,
Original file line number	Diff line number	Diff line change
Expand Up		@@ -5,3 +5,5 @@ export const INNATE_MAGIC_REGEN = 0.05;
		export const BASE_MAX_ESSENCE = 5;

		export const POTENT_MANA_MULTIPLIER = 0.03;

		export const BASE_EVOKER_RANGE = 25;