Enhancement 11.0.5 (WoWAnalyzer#7181)

* initial * progress * updating enhancement to 11.0.5 * elemental updates for 11.0.5 * initial * progress * updating enhancement to 11.0.5 * elemental updates for 11.0.5
Krealle · Nov 17, 2024 · 1723e9d · 1723e9d
1 parent 511f427
commit 1723e9d
Show file tree

Hide file tree

Showing 33 changed files with 725 additions and 610 deletions.
diff --git a/scripts/talents/generate-talents.ts b/scripts/talents/generate-talents.ts
@@ -25,8 +25,8 @@ import {
 const LIVE_WOW_BUILD_NUMBER = '11.0.5.57388';
 const LIVE_TALENT_DATA_URL = 'https://www.raidbots.com/static/data/live/talents.json';
 const LIVE_SPELLPOWER_DATA_URL = `https://wago.tools/db2/SpellPower/csv?build=${LIVE_WOW_BUILD_NUMBER}`;
-const PTR_WOW_BUILD_NUMBER = '11.0.2.55763';
-const PTR_TALENT_DATA_URL = 'https://www.raidbots.com/static/data/beta/talents.json';
+const PTR_WOW_BUILD_NUMBER = '11.0.5.56865';
+const PTR_TALENT_DATA_URL = `https://www.raidbots.com/static/data/${PTR_WOW_BUILD_NUMBER}/talents.json`;
 const PTR_SPELLPOWER_DATA_URL = `https://wago.tools/db2/SpellPower/csv?build=${PTR_WOW_BUILD_NUMBER}`;
 
 const classes: { [classId: number]: { name: string; baseMaxResource: number } } = {

diff --git a/src/analysis/retail/shaman/elemental/CHANGELOG.tsx b/src/analysis/retail/shaman/elemental/CHANGELOG.tsx
@@ -7,6 +7,7 @@ import SpellLink from 'interface/SpellLink';
 
 // prettier-ignore
 export default [
+  change(date(2024, 11, 17), <>Initial support for 11.0.5</>, Seriousnes),
   change(date(2024, 9, 28), <>Fixed <SpellLink spell={TALENTS.SURGE_OF_POWER_TALENT} /> statistic incorrectly showing as <SpellLink spell={TALENTS.MASTER_OF_THE_ELEMENTS_ELEMENTAL_TALENT} /></>, Seriousnes),
   change(date(2024, 9, 28), <>Updating <SpellLink spell={TALENTS.STORMKEEPER_TALENT} /> analysis</>, Seriousnes),
   change(date(2024, 9, 27), <>Added guide section for <SpellLink spell={TALENTS.PRIMAL_ELEMENTALIST_TALENT} /> usage.</>, Seriousnes),

diff --git a/src/analysis/retail/shaman/elemental/CONFIG.tsx b/src/analysis/retail/shaman/elemental/CONFIG.tsx
@@ -10,7 +10,7 @@ export default {
   contributors: [Awildfivreld, Periodic, Seriousnes],
   branch: GameBranch.Retail,
   // The WoW client patch this spec was last updated.
-  patchCompatibility: '11.0.2',
+  patchCompatibility: '11.0.5',
   supportLevel: SupportLevel.MaintainedFull,
   // Explain the status of this spec's analysis here. Try to mention how complete it is, and perhaps show links to places users can learn more.
   // If this spec's analysis does not show a complete picture please mention this in the `<Warning>` component.

diff --git a/src/analysis/retail/shaman/elemental/CombatLogParser.tsx b/src/analysis/retail/shaman/elemental/CombatLogParser.tsx
@@ -24,7 +24,6 @@ import PrimalFireElemental from './modules/talents/PrimalFireElemental';
 import PrimalStormElemental from './modules/talents/PrimalStormElemental';
 import StormElemental from './modules/talents/StormElemental';
 import Stormkeeper from './modules/talents/Stormkeeper';
-import FlashOfLightning from './modules/talents/FlashOfLightning';
 import SurgeOfPower from './modules/talents/SurgeOfPower';
 import ElementalOrbit from '../shared/talents/ElementalOrbit';
 import EarthenHarmony from '../restoration/modules/talents/EarthenHarmony';
@@ -35,7 +34,6 @@ import SpenderWindow from './modules/features/SpenderWindow';
 import MaelstromTracker from './modules/resources/MaelstromTracker';
 import MaelstromDetails from './modules/resources/MaelstromDetails';
 import MaelstromGraph from './modules/resources/MaelstromGraph';
-import SkybreakersFieryDemise from './modules/talents/SkybreakersFieryDemise';
 import { StormbringerTab } from '../shared/hero/stormbringer/StormbringerTab';
 import Tempest from '../shared/hero/stormbringer/Tempest';
 import StormbringerEventOrderNormalizer from '../shared/hero/stormbringer/normalizers/StormbringerEventOrderNormalizer';
@@ -78,8 +76,6 @@ class CombatLogParser extends CoreCombatLogParser {
     stormkeeper: Stormkeeper,
     ascendance: Ascendance,
     manaSpring: ManaSpring,
-    skybreakersFieryDemise: SkybreakersFieryDemise,
-    flashOfLightning: FlashOfLightning,
 
     // hero talents
     stormbringerTab: StormbringerTab,

diff --git a/src/analysis/retail/shaman/elemental/guide/FlameShockSubSection.tsx b/src/analysis/retail/shaman/elemental/guide/FlameShockSubSection.tsx
@@ -48,7 +48,7 @@ export const FlameShockSubSection = ({
           {formatPercentage((modules.flameShock as FlameShock).uptime)}% <small>uptime</small>
           <div
             style={{
-              height: '40px' /* UptimeStackBar floats and doesn't have an intrinsic height */,
+              height: '24px' /* UptimeStackBar floats and doesn't have an intrinsic height */,
             }}
           >
             {
@@ -59,7 +59,7 @@ export const FlameShockSubSection = ({
             <UptimeStackBar
               start={info.fightStart}
               end={info.fightEnd}
-              barColor="#ac1f39"
+              barColor="#4ec04e"
               timeTooltip
               {...modules.flameShock.getDebuffStackHistory()}
             />

diff --git a/src/analysis/retail/shaman/elemental/modules/Abilities.tsx b/src/analysis/retail/shaman/elemental/modules/Abilities.tsx
@@ -71,7 +71,7 @@ class Abilities extends ClassAbilities {
         spell: TALENTS.ASCENDANCE_ELEMENTAL_TALENT.id,
         enabled: combatant.hasTalent(TALENTS.ASCENDANCE_ELEMENTAL_TALENT),
         category: SPELL_CATEGORY.COOLDOWNS,
-        cooldown: 180,
+        cooldown: 180 - (combatant.hasTalent(TALENTS.FIRST_ASCENDANT_TALENT) ? 60 : 0),
         gcd: {
           base: 1500,
         },
@@ -143,6 +143,14 @@ class Abilities extends ClassAbilities {
           static: 0,
         },
       },
+      {
+        spell: SPELLS.TEMPEST_CAST.id,
+        enabled: combatant.hasTalent(TALENTS.TEMPEST_TALENT),
+        category: SPELL_CATEGORY.ROTATIONAL,
+        gcd: {
+          base: 1500,
+        },
+      },
     ];
   }
 }