Skip to content

Commit

Permalink
add range to spells to fix inconsistencies with APL range check
Browse files Browse the repository at this point in the history
  • Loading branch information
Krealle committed Mar 17, 2024
1 parent a771307 commit 2dcecab
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/analysis/retail/evoker/devastation/modules/Abilities.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ class Abilities extends CoreAbilities {
gcd: {
base: 1500,
},
range: 25,
enabled: combatant.hasTalent(TALENTS.PYRE_TALENT),
},
{
Expand All @@ -28,6 +29,7 @@ class Abilities extends CoreAbilities {
suggestion: true,
recommendedEfficiency: 0.9,
},
range: 25,
enabled: combatant.hasTalent(TALENTS.FIRESTORM_TALENT),
},
{
Expand All @@ -43,6 +45,7 @@ class Abilities extends CoreAbilities {
suggestion: true,
recommendedEfficiency: 0.95,
},
range: 25,
enabled: combatant.hasTalent(TALENTS.ETERNITY_SURGE_TALENT),
},
{
Expand All @@ -57,6 +60,7 @@ class Abilities extends CoreAbilities {
recommendedEfficiency: 0.9,
extraSuggestion: 'You should aim to use this off CD.',
},
range: 25,
enabled: combatant.hasTalent(TALENTS.SHATTERING_STAR_TALENT),
},
//endregion
Expand Down
6 changes: 6 additions & 0 deletions src/analysis/retail/evoker/shared/modules/Abilities.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ class Abilities extends CoreAbilities {
gcd: {
base: 1500,
},
range: 25,
enabled: combatant.spec !== SPECS.AUGMENTATION_EVOKER,
},
{
Expand All @@ -41,6 +42,7 @@ class Abilities extends CoreAbilities {
gcd: {
base: 1500,
},
range: 25,
damageSpellIds: [SPELLS.EMERALD_BLOSSOM_CAST.id],
isDefensive: true,
},
Expand All @@ -62,13 +64,15 @@ class Abilities extends CoreAbilities {
recommendedEfficiency: 0.95,
},
}),
range: 25,
},
{
spell: SPELLS.LIVING_FLAME_CAST.id,
category: SPELL_CATEGORY.ROTATIONAL,
gcd: {
base: 1500,
},
range: 25,
damageSpellIds: [SPELLS.LIVING_FLAME_DAMAGE.id],
},
{
Expand All @@ -78,6 +82,7 @@ class Abilities extends CoreAbilities {
? SPELL_CATEGORY.HEALER_DAMAGING_SPELL
: SPELL_CATEGORY.ROTATIONAL,
cooldown: 0,
range: 25,
gcd: {
base: 1500,
},
Expand Down Expand Up @@ -181,6 +186,7 @@ class Abilities extends CoreAbilities {
gcd: {
base: 1500,
},
range: 25,
},
{
spell: TALENTS.OPPRESSING_ROAR_TALENT.id,
Expand Down

0 comments on commit 2dcecab

Please sign in to comment.