Skip to content

Commit

Permalink
deleted mind game references from holy priest (WoWAnalyzer#6950)
Browse files Browse the repository at this point in the history
* deleted mindgames ref for hpriest and enabled tww

* removed changelog comment
  • Loading branch information
Liavre authored Aug 14, 2024
1 parent 395f4fa commit 38e47d8
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 11 deletions.
6 changes: 6 additions & 0 deletions src/CONTRIBUTORS.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2454,3 +2454,9 @@ export const Lithix: Contributor = {
github: 'Yitaarli',
discord: 'lithix#0749',
};

export const Liavre: Contributor = {
nickname: 'Liavre',
github: 'Liavre',
discord: 'Liavre',
};
3 changes: 2 additions & 1 deletion src/analysis/retail/priest/holy/CHANGELOG.tsx
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import { change, date } from 'common/changelog';
import SPELLS from 'common/SPELLS';
import TALENTS, { TALENTS_PRIEST } from 'common/TALENTS/priest';
import { Arlie, Hana, Litena, Squided, ToppleTheNun, Trevor, Saeldur } from 'CONTRIBUTORS';
import { Arlie, Hana, Litena, Liavre, Squided, ToppleTheNun, Trevor, Saeldur } from 'CONTRIBUTORS';
import { SpellLink } from 'interface';

export default [
change(date(2024, 8, 13), <>Deleted references to Mindgames (old talent) </>, Liavre),
change(date(2024, 4, 20), <>Fix cooldown of <SpellLink spell={SPELLS.DESPERATE_PRAYER} /> when using <SpellLink spell={TALENTS_PRIEST.ANGELS_MERCY_TALENT} />.</>, Arlie),
change(
date(2024, 4, 18),
Expand Down
12 changes: 6 additions & 6 deletions src/analysis/retail/priest/holy/CONFIG.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { Litena, Squided } from 'CONTRIBUTORS';
import GameBranch from 'game/GameBranch';
import SPECS from 'game/SPECS';
import Config, { SupportLevel } from 'parser/Config';
// import CHANGELOG from './CHANGELOG';
import CHANGELOG from './CHANGELOG';

//Description not accurate as of Dragonflight update
const config: Config = {
Expand Down Expand Up @@ -40,12 +40,12 @@ const config: Config = {
// The current spec identifier. This is the only place (in code) that specifies which spec this parser is about.
spec: SPECS.HOLY_PRIEST,
// The contents of your changelog.
// changelog: CHANGELOG,
changelog: CHANGELOG,
// The CombatLogParser class for your spec.
// parser: () =>
// import('./CombatLogParser' /* webpackChunkName: "HolyPriest" */).then(
// (exports) => exports.default,
// ),
parser: () =>
import('./CombatLogParser' /* webpackChunkName: "HolyPriest" */).then(
(exports) => exports.default,
),
// The path to the current directory (relative form project root). This is used for generating a GitHub link directly to your spec's code.
path: import.meta.url,
};
Expand Down
3 changes: 1 addition & 2 deletions src/analysis/retail/priest/holy/CombatLogParser.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import AbilityTracker from 'analysis/retail/priest/holy/modules/core/AbilityTracker';
import { Mindgames, TranslucentImage } from 'analysis/retail/priest/shared';
import { TranslucentImage } from 'analysis/retail/priest/shared';
import CoreCombatLogParser from 'parser/core/CombatLogParser';
import ManaTracker from 'parser/core/healingEfficiency/ManaTracker';
import LowHealthHealing from 'parser/shared/modules/features/LowHealthHealing';
Expand Down Expand Up @@ -120,7 +120,6 @@ class CombatLogParser extends CoreCombatLogParser {
Benediction: Talents.MiddleRow.Benediction,
RevitalizingPrayers: Talents.MiddleRow.RevitalizingPrayers,
DivineStar: Talents.Classwide.DivineStar,
Mindgames: Mindgames,
DivineWord: Talents.BottomRow.DivineWord,

HolyWordSalvation: Talents.BottomRow.HolyWordSalvation,
Expand Down
2 changes: 0 additions & 2 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@
"src/analysis/retail/deathknight/unholy",
"src/analysis/retail/monk/windwalker",
"src/analysis/retail/priest/discipline",
"src/analysis/retail/priest/holy",
"src/analysis/retail/rogue/assassination",
"src/analysis/retail/rogue/subtlety",
"src/analysis/retail/rogue/outlaw",
Expand All @@ -64,7 +63,6 @@
"./src/analysis/retail/deathknight/unholy/CONFIG.tsx",
"./src/analysis/retail/mage/frost/CONFIG.tsx",
"./src/analysis/retail/priest/discipline/CONFIG.tsx",
"./src/analysis/retail/priest/holy/CONFIG.tsx",
"./src/analysis/retail/rogue/assassination/CONFIG.tsx",
"./src/analysis/retail/rogue/subtlety/CONFIG.tsx",
"./src/analysis/retail/rogue/outlaw/CONFIG.tsx",
Expand Down

0 comments on commit 38e47d8

Please sign in to comment.