[Classic] Cata DK Spells (WoWAnalyzer#7017)

Co-authored-by: J David Smith <[email protected]>

src/CHANGELOG.tsx

@@ -37,6 +37,7 @@ import SpellLink from 'interface/SpellLink';
 export default [
   change(date(2024, 9, 12), 'Fixed crash when analyzing reports where 0 procs of certain effects ocurred.', emallson),
   change(date(2024, 9, 12), 'Add support for Earthen characters.', ToppleTheNun),
+  change(date(2024, 9, 11), 'Update Death Knight spells for Classic Cataclysm', jazminite),
   change(date(2024, 9, 10), 'Change behavior of getLowestPerf when no perfs are provided', Trevor),
   change(date(2024, 9, 9), 'Fix character search showing UNKNOWN instead of THE WAR WITHIN.', ToppleTheNun),
   change(date(2024, 9, 8), "Add Nerub'ar Palace bosses and season 1 M+ dungeons.", ToppleTheNun),

src/analysis/classic/deathknight/frost/CombatLogParser.ts

@@ -1,8 +1,6 @@
 // Base file
 import BaseCombatLogParser from 'parser/classic/CombatLogParser';
 // Shared
-import lowRankSpellsSuggestion from 'parser/classic/suggestions/lowRankSpells';
-import { lowRankSpells, GlobalCooldown } from 'analysis/classic/deathknight/shared';
 // Features
 import Abilities from './modules/features/Abilities';
 import AlwaysBeCasting from './modules/features/AlwaysBeCasting';
@@ -14,8 +12,6 @@ import Checklist from './modules/checklist/Module';
 class CombatLogParser extends BaseCombatLogParser {
   static specModules = {
     // Shared
-    lowRankSpells: lowRankSpellsSuggestion(lowRankSpells),
-    globalCooldown: GlobalCooldown,
     // Features
     abilities: Abilities,
     alwaysBeCasting: AlwaysBeCasting,

src/analysis/classic/deathknight/frost/modules/checklist/Component.tsx

@@ -39,7 +39,7 @@ const MeleeChecklist = ({ combatant, castEfficiency, thresholds }: ChecklistProp
         description={<>Use your cooldowns as often as possible to maximize your damage output.</>}
       >
         {/* SPELLS listed here must be in ../features/Abilities */}
-        <AbilityRequirement spell={SPELLS.UNBREAKABLE_ARMOR.id} />
+        <AbilityRequirement spell={SPELLS.PILLAR_OF_FROST.id} />
         <AbilityRequirement spell={SPELLS.EMPOWER_RUNE_WEAPON.id} />
         <AbilityRequirement spell={SPELLS.ARMY_OF_THE_DEAD.id} />
       </Rule>

src/analysis/classic/deathknight/frost/modules/features/Abilities.ts

@@ -11,11 +11,6 @@ class Abilities extends CoreAbilities {
         category: SPELL_CATEGORY.ROTATIONAL,
         gcd: { base: 1500 },
       },
-      {
-        spell: SPELLS.FROST_STRIKE.id,
-        category: SPELL_CATEGORY.ROTATIONAL,
-        gcd: { base: 1500 },
-      },
       {
         spell: SPELLS.BLOOD_STRIKE.id,
         category: SPELL_CATEGORY.ROTATIONAL,
@@ -64,7 +59,7 @@ class Abilities extends CoreAbilities {
       },
       // Cooldowns
       {
-        spell: [SPELLS.UNBREAKABLE_ARMOR.id],
+        spell: [SPELLS.PILLAR_OF_FROST.id],
         category: SPELL_CATEGORY.COOLDOWNS,
         gcd: null,
         cooldown: 60,

src/analysis/classic/deathknight/frost/modules/features/Buffs.tsx

@@ -20,7 +20,7 @@ class Buffs extends CoreAuras {
         timelineHighlight: true,
       },
       {
-        spellId: SPELLS.UNBREAKABLE_ARMOR.id,
+        spellId: SPELLS.PILLAR_OF_FROST.id,
         timelineHighlight: true,
       },
       {

src/analysis/classic/deathknight/shared/GlobalCooldown.ts

@@ -2,12 +2,9 @@ import SPELLS from 'common/SPELLS/classic/deathknight';
 import CoreGlobalCooldown from 'parser/shared/modules/GlobalCooldown';
 
 const UNHOLY_PRESENCE_GCD_REDUCTION = 500;
-const ICY_TALONS_GCD_REDUCTION = 0.2;
 
 /**
  * Unholy presence reduces the GCD of all casts by 0.5 seconds
- * Icy Talons reduces the GCD of all casts by 20%
- * Min GCD is 0.75 seconds
  */
 
 class GlobalCooldown extends CoreGlobalCooldown {
@@ -16,9 +13,6 @@ class GlobalCooldown extends CoreGlobalCooldown {
     if (gcd && this.selectedCombatant.hasBuff(SPELLS.UNHOLY_PRESENCE.id)) {
       return Math.max(gcd - UNHOLY_PRESENCE_GCD_REDUCTION, this.minDuration);
     }
-    if (gcd && this.selectedCombatant.hasBuff(SPELLS.ICY_TALONS_BUFF.id)) {
-      return Math.max(gcd * (1 - ICY_TALONS_GCD_REDUCTION), this.minDuration);
-    }
     return gcd;
   }
 }

src/analysis/classic/deathknight/shared/index.ts

@@ -1,2 +1 @@
-export { default as lowRankSpells } from './lowRankSpells';
 export { default as GlobalCooldown } from './GlobalCooldown';

src/analysis/classic/deathknight/unholy/modules/features/Abilities.ts

@@ -32,7 +32,7 @@ class Abilities extends CoreAbilities {
         gcd: { base: 1500 },
       },
       {
-        spell: [SPELLS.GHOUL_FRENZY.id],
+        spell: [SPELLS.DARK_TRANSFORMATION.id],
         category: SPELL_CATEGORY.ROTATIONAL,
         gcd: { base: 1500 },
       },
@@ -62,11 +62,6 @@ class Abilities extends CoreAbilities {
         category: SPELL_CATEGORY.ROTATIONAL_AOE,
         gcd: { base: 1500 },
       },
-      {
-        spell: SPELLS.CORPSE_EXPLOSION.id,
-        category: SPELL_CATEGORY.ROTATIONAL_AOE,
-        gcd: { base: 1500 },
-      },
       // Cooldowns
       {
         spell: [SPELLS.SUMMON_GARGOYLE.id],