Merge pull request WoWAnalyzer#6597 from ToppleTheNun/fyralath

add basic support for Fyr'alath

src/CHANGELOG.tsx

@@ -32,6 +32,7 @@ import SpellLink from 'interface/SpellLink';
 
 // prettier-ignore
 export default [
+  change(date(2024, 1, 7), <>Add checklist support for <ItemLink id={ITEMS.FYRALATH.id} />.</>, ToppleTheNun),
   change(date(2024, 1, 4), <>Add statistics for <ItemLink id={ITEMS.ECHOING_TYRSTONE.id}/>.</>, Arbixal),
   change(date(2024, 1, 2), 'Remove Shadowlands food and augment rune support.', ToppleTheNun),
   change(date(2023, 12, 30), 'Fix errors caused by ESLint update.', ToppleTheNun),

src/analysis/retail/paladin/retribution/CHANGELOG.tsx

@@ -1,7 +1,10 @@
 import { change, date } from 'common/changelog';
 import { emallson, Klamuz, ToppleTheNun, xizbow } from 'CONTRIBUTORS';
+import { ItemLink } from 'interface';
+import ITEMS from 'common/ITEMS';
 
 export default [
+  change(date(2024, 1, 7), <>Add <ItemLink id={ITEMS.FYRALATH.id} /> to cooldown graph.</>, ToppleTheNun),
   change(date(2023, 7, 19), 'Make CooldownGraphSubsection generic enough that it can be used by other specs.', ToppleTheNun),
   change(date(2023, 7, 18), 'Show percentage wasted Holy Power instead of percentage at Holy Power cap.', ToppleTheNun),
   change(date(2023, 7, 16), 'First pass at a Guide for Ret Paladin.', ToppleTheNun),

src/analysis/retail/paladin/retribution/Guide.tsx

@@ -8,6 +8,8 @@ import HideExplanationsToggle from 'interface/guide/components/HideExplanationsT
 import HideGoodCastsToggle from 'interface/guide/components/HideGoodCastsToggle';
 import { QualitativePerformance } from 'parser/ui/QualitativePerformance';
 import PerformancePercentage from 'analysis/retail/demonhunter/shared/guide/PerformancePercentage';
+import DRAGONFLIGHT_OTHERS_ITEMS from 'common/ITEMS/dragonflight/others';
+import DRAGONFLIGHT_OTHERS_SPELLS from 'common/SPELLS/dragonflight/others';
 import TALENTS from 'common/TALENTS/paladin';
 import SpellLink from 'interface/SpellLink';
 import CooldownGraphSubsection, {
@@ -117,6 +119,10 @@ const cooldowns: Cooldown[] = [
     spell: TALENTS.DIVINE_TOLL_TALENT,
     isActive: (c) => c.hasTalent(TALENTS.DIVINE_TOLL_TALENT),
   },
+  {
+    spell: DRAGONFLIGHT_OTHERS_SPELLS.RAGE_OF_FYRALATH_1,
+    isActive: (c) => c.hasMainHand(DRAGONFLIGHT_OTHERS_ITEMS.FYRALATH.id),
+  },
 ];
 function CooldownSection() {
   return (

src/common/ITEMS/dragonflight/others.ts

@@ -76,6 +76,11 @@ const others = {
     name: 'Echoing Tyrstone',
     icon: 'ability_paladin_lightofthemartyr',
   },
+  FYRALATH: {
+    id: 206448,
+    name: "Fyr'alath the Dreamrender",
+    icon: 'inv_axe_2h_fyrakk_d_01_shadowflame',
+  },
 } satisfies Record<string, Item>;
 
 export default others;

src/common/SPELLS/dragonflight/others.ts

@@ -22,6 +22,26 @@ const others = {
     name: 'Disintegrate',
     icon: 'ability_evoker_disintegrate',
   },
+  RAGE_OF_FYRALATH_1: {
+    id: 417131,
+    name: "Rage of Fyr'alath",
+    icon: 'inv_axe_2h_fyrakk_d_01_shadowflame',
+  },
+  RAGE_OF_FYRALATH_2: {
+    id: 417132,
+    name: "Rage of Fyr'alath",
+    icon: 'inv_axe_2h_fyrakk_d_01_shadowflame',
+  },
+  RAGE_OF_FYRALATH_DAMAGE_1: {
+    id: 417134,
+    name: "Rage of Fyr'alath",
+    icon: 'inv_axe_2h_fyrakk_d_01_shadowflame',
+  },
+  RAGE_OF_FYRALATH_DAMAGE_2: {
+    id: 424094,
+    name: "Rage of Fyr'alath",
+    icon: 'inv_axe_2h_fyrakk_d_01_shadowflame',
+  },
 } satisfies Record<string, Spell>;
 
 export default others;

src/interface/BAD_ICONS.ts

@@ -24,5 +24,6 @@ const BAD_ICONS = [
   'spell_priest_void_flay',
   'spell_priest_shadow_mend',
   'spell_priest_void_blast',
+  'inv_axe_2h_fyrakk_d_01_shadowflame',
 ];
 export default BAD_ICONS;

src/parser/core/CASTS_THAT_ARENT_CASTS.ts

@@ -27,6 +27,10 @@ const spells: number[] = [
   SPELLS.RIONTHUS_DISINTEGRATE.id, // targeted player is shown as 'casting' this spell
   //endregion
 
+  //region Items
+  SPELLS.RAGE_OF_FYRALATH_2.id, // second cast logged by Fyr'alath
+  //endregion
+
   //region Consumables
   //endregion
 

src/parser/core/CombatLogParser.tsx

@@ -107,6 +107,7 @@ import VoiceOfTheSilentStar from 'parser/retail/modules/items/dragonflight/Voice
 import AmalgamsSeventhSpine from 'parser/retail/modules/items/dragonflight/AmalgamsSeventhSpine';
 import ElementalLariat from 'parser/retail/modules/items/dragonflight/ElementalLariat';
 import EchoingTyrstone from 'parser/retail/modules/items/dragonflight/EchoingTyrstone';
+import Fyralath from 'parser/retail/modules/items/dragonflight/Fyralath';
 
 // This prints to console anything that the DI has to do
 const debugDependencyInjection = false;
@@ -227,6 +228,7 @@ class CombatLogParser {
     amalgamsSeventhSpine: AmalgamsSeventhSpine,
     elementalLariat: ElementalLariat,
     echoingTyrstone: EchoingTyrstone,
+    fyralath: Fyralath,
 
     // Enchants
     burningDevotion: BurningDevotion,

src/parser/retail/modules/items/dragonflight/Fyralath.tsx

@@ -0,0 +1,27 @@
+import Analyzer, { Options } from 'parser/core/Analyzer';
+import ITEMS from 'common/ITEMS/dragonflight/others';
+import SPELLS from 'common/SPELLS/dragonflight/others';
+import Abilities from 'parser/core/modules/Abilities';
+import SPELL_CATEGORY from 'parser/core/SPELL_CATEGORY';
+
+const deps = {
+  abilities: Abilities,
+};
+export default class Fyralath extends Analyzer.withDependencies(deps) {
+  constructor(options: Options) {
+    super(options);
+    this.active = this.selectedCombatant.hasMainHand(ITEMS.FYRALATH.id);
+    if (this.active) {
+      this.deps.abilities.add({
+        spell: SPELLS.RAGE_OF_FYRALATH_1.id,
+        category: SPELL_CATEGORY.COOLDOWNS,
+        cooldown: 120,
+        castEfficiency: {
+          suggestion: true,
+          recommendedEfficiency: 0.9,
+        },
+        damageSpellIds: [SPELLS.RAGE_OF_FYRALATH_DAMAGE_1.id, SPELLS.RAGE_OF_FYRALATH_DAMAGE_2.id],
+      });
+    }
+  }
+}