Skip to content

Commit

Permalink
frost_mage: fix typo in comet storm cast info (WoWAnalyzer#7194)
Browse files Browse the repository at this point in the history
* frost_mage: fix typo in comet storm cast info

very simple grammatical fix from hitted to hit.

* updated the changelog explaining the change in this branch

* added a corresponding entry in contributors and updated changelog name accordingly

* including the contributor from the log

---------

Co-authored-by: Shiv S <[email protected]>
  • Loading branch information
Soulhealer95 and Shiv S authored Nov 23, 2024
1 parent 9e39126 commit c0328ba
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 6 deletions.
17 changes: 13 additions & 4 deletions src/CONTRIBUTORS.ts
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,19 @@ export const Sref: Contributor = {
discord: 'Sref#1337',
avatar: avatar('sref-avatar.jpg'),
};

export const Soulhealer95: Contributor = {
nickname: 'Soul',
github: 'Soulhealer95',
mains: [
{
name: 'Soulmerlin',
spec: SPECS.FROST_MAGE,
link: 'https://www.warcraftlogs.com/character/us/sargeras/soulmerlin',
},
],
};

export const Iskalla: Contributor = {
nickname: 'Iskalla',
github: 'Iskalla',
Expand All @@ -159,10 +172,6 @@ export const Skamer: Contributor = {
nickname: 'Skamer',
github: 'Skamer',
};
export const Soulhealer95: Contributor = {
nickname: 'Soulhealer',
github: 'Soulhealer95',
};
export const Salarissia: Contributor = {
nickname: 'Salarissia',
github: 'Salarissia',
Expand Down
3 changes: 2 additions & 1 deletion src/analysis/retail/mage/frost/CHANGELOG.tsx
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import { change, date } from 'common/changelog';
import { SpellLink } from 'interface';
import { Sharrq, Earosselot } from 'CONTRIBUTORS';
import { Sharrq, Earosselot, Soulhealer95 } from 'CONTRIBUTORS';
import TALENTS from 'common/TALENTS/mage';

// prettier-ignore
export default [
change(date(2024, 11, 22), <>Fixed a typo in the comet storm hit description</>, Soulhealer95),
change(date(2024, 10, 18), <>Apls: Updated for Spell Slinger and added for Frostfire for patch 11.0.5</>, Earosselot),
change(date(2024, 10, 17), <>Fixed Frostfire Bolt on Winters Chill module for Frostfire.</>, Earosselot),
change(date(2024, 9, 18), <>Updated the Warning Banner explaining the current state of Frost Mage.</>, Sharrq),
Expand Down
2 changes: 1 addition & 1 deletion src/analysis/retail/mage/frost/talents/CometStorm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class CometStorm extends Analyzer {
this.cometStorm.push(cometStormDetails);

let performance = QualitativePerformance.Fail;
const count = `${cometStormDetails.shatteredHits} shattered hits / ${cometStormDetails.enemiesHit.length} enemies hitted`;
const count = `${cometStormDetails.shatteredHits} shattered hits / ${cometStormDetails.enemiesHit.length} enemies hit`;
if (enemies.length === 1) {
if (cometStormDetails.shatteredHits >= 7) {
performance = QualitativePerformance.Perfect;
Expand Down

0 comments on commit c0328ba

Please sign in to comment.