Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leaping #2

Closed
wants to merge 5 commits into from
Closed

Leaping #2

wants to merge 5 commits into from

Conversation

Krealle
Copy link
Owner

@Krealle Krealle commented Apr 7, 2024

Description

Testing

  • Test report URL: /report/...
  • Screenshot(s):

Krealle
Krealle commented Apr 7, 2024
View reviewed changes
Copy link
Owner Author

@Krealle Krealle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm

src/analysis/retail/evoker/augmentation/modules/normalizers/CastLinkNormalizer.ts
if (!HasTarget(linkingEvent) && !HasTarget(referencedEvent)) {
return true;
}
return encodeEventTargetString(linkingEvent) !== encodeEventTargetString(referencedEvent);
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return encodeEventTargetString(linkingEvent) !== encodeEventTargetString(referencedEvent);
return test

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wonder

@Krealle Krealle closed this Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Dragonflight Evoker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Krealle