feature: Add make style target and refactor RAJA with clang-format

[johnbowen42]

This PR applies clang-format to the include and src directories of develop

[johnbowen42]

@rhornung67 and I worked on the settings this morning. Here is what we settled on:

• RAJA/.clang-format

  Lines 12 to 16 in c5bee85

  	# Alignment of consecutive declarations, assignments etc
  	AlignConsecutiveAssignments : true
  	AlignConsecutiveDeclarations : false
  	AlignConsecutiveMacros : true
  	AlignTrailingComments : true

  • example:

  • RAJA/include/RAJA/index/IndexValue.hpp

    Lines 53 to 57 in c5bee85

    	RAJA_INLINE constexpr IndexValue() = default;
    	constexpr RAJA_INLINE IndexValue(IndexValue const&) = default;
    	constexpr RAJA_INLINE IndexValue(IndexValue&&) = default;
    	RAJA_INLINE IndexValue& operator=(IndexValue const&) = default;
    	RAJA_INLINE IndexValue& operator=(IndexValue&&) = default;

• RAJA/.clang-format

  Lines 20 to 37 in c5bee85

  	BraceWrapping:
  	AfterCaseLabel: true
  	AfterClass: true
  	AfterControlStatement: true
  	AfterEnum: true
  	AfterFunction: true
  	AfterNamespace: true
  	AfterObjCDeclaration: false
  	AfterStruct: true
  	AfterUnion: true
  	AfterExternBlock: false
  	BeforeCatch: true
  	BeforeElse: true
  	BeforeLambdaBody: false
  	IndentBraces: false
  	SplitEmptyFunction: false
  	SplitEmptyRecord: false
  	SplitEmptyNamespace: false

  • This transparently controls whether a curly brace will occur on the next line following anything requiring a curly brace. Basically the only time we don't enforce curly brace on next line is for lambda body definitions and empty function definitions. Another notable exception is single line lambdas:

    RAJA/.clang-format

    Line 47 in c5bee85

    AllowShortLambdasOnASingleLine : None

• RAJA/.clang-format

  Line 50 in c5bee85

  BinPackArguments : true

  • a function call’s arguments will either be all on the same line or will have one line each.

  • RAJA/include/RAJA/index/IndexSetUtils.hpp

    Lines 51 to 54 in c5bee85

    	CONTAINER_T tcon;
    	forall<ExecPolicy<seq_segit, seq_exec>>(
    	iset, [&](typename CONTAINER_T::value_type idx) {
    	tcon.push_back(idx);

  • RAJA/include/RAJA/index/IndexSetUtils.hpp

    Lines 68 to 72 in c5bee85

    	{
    	CONTAINER_T tcon;
    	forall<seq_exec>(seg, [&](typename CONTAINER_T::value_type idx) {
    	tcon.push_back(idx);
    	});

  • The difference here is caused by

    RAJA/.clang-format

    Line 53 in c5bee85

    ColumnLimit : 80

• RAJA/.clang-format

  Line 51 in c5bee85

  BinPackParameters : false

  • This doesn't enforce the same packing for parameters in function declarations

• RAJA/.clang-format

  Line 56 in c5bee85

  AlignAfterOpenBracket: Align

  • example

    RAJA/include/RAJA/pattern/forall.hpp

    Lines 148 to 155 in c5bee85

    	RAJA_INLINE camp::resources::EventProxy<Res> operator()(T const&,
    	ExecPol,
    	Body,
    	Res,
    	ForallParams) const;
    	const int start;
    	};

• RAJA/.clang-format

  Line 67 in c5bee85

  LambdaBodyIndentation : Signature

  • disallow single line lambdas, and indent the body one indent level relative to the indent level of the signature, e.g.

    RAJA/include/RAJA/index/IndexSetUtils.hpp

    Lines 109 to 114 in c5bee85

    	{
    	CONTAINER_T tcon;
    	forall<seq_exec>(seg, [&](typename CONTAINER_T::value_type idx) {
    	if (conditional(idx)) tcon.push_back(idx);
    	});
    	con = tcon;

• RAJA/.clang-format

  Line 69 in c5bee85

  SeparateDefinitionBlocks : Always

  • enforce spacing between functions and other blocks, e.g.

    RAJA/include/RAJA/index/IndexValue.hpp

    Lines 250 to 259 in c5bee85

    	{
    	return (value >= x.value);
    	}
    	RAJA_HOST_DEVICE RAJA_INLINE bool operator==(value_type x) const
    	{
    	return (value == x);
    	}
    	RAJA_HOST_DEVICE RAJA_INLINE bool operator==(TYPE x) const