Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibWeb: Add the search element #2444

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

Psychpsyo
Copy link
Contributor

This adds the search element.

Copy link
Member

@tcl3 tcl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I've spotted a couple more places where search elements are mentioned in the spec:

If there's a test you could add that exercises the new functionality, that would be great.

@Psychpsyo
Copy link
Contributor Author

Psychpsyo commented Nov 19, 2024

I think I've spotted a couple more places where search elements are mentioned in the spec:

* `HTMLParser::is_special_tag()` (see: https://html.spec.whatwg.org/multipage/parsing.html#special)

* `HTMLElement::default_role()` (see: https://www.w3.org/TR/html-aria/#el-search)

If there's a test you could add that exercises the new functionality, that would be great.

Turns out that we already had the WPT test for this imported and I've just changed the expectations on that one to pass.

@tcl3 tcl3 merged commit f09ed59 into LadybirdBrowser:master Nov 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants