Updated OFTCoreV2 for convenient use of the address format bytes32. #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I've been working with OFTV2 and noticed that during payload decoding in the _decodeSendPayload function to retrieve the 'to' address using the toAddress method, you were dropping the first 12 bytes of bytes32. Typically, when converting a bytes20 address to bytes32, we pad with zeros at the end rather than the beginning. Therefore, I made a correction for more convenient use. Additionally, in the OFTCoreV2 contract, ExcessivelySafeCall is imported, but it seems unnecessary since this library is already imported in the inherited NonblockingLzApp contract.