Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

LIVE-1940 Rework of staking flow for ATOM #4972

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Conversation

henri-ly
Copy link
Contributor

@henri-ly henri-ly commented May 11, 2022

🦒 Context (issues, jira)

Screenshot 2022-05-10 at 16 23 41

Screenshot 2022-05-10 at 16 23 46

Screenshot 2022-05-10 at 16 23 53

💻 Description / Demo (image or video)

Rework of validator flow for Cosmos according to the Figma

🖤 Expectations to reach

PR must pass CI, rebase develop if conflicts. Thanks!

  • on QA: at least one of these two checkboxes must be checked:
    • a specific test planned is defined on Jira
    • this PR is covered by automatic UI test
  • on delivery: at least one of these two checkboxes must be checked:
    • Option 1: no impact: The changes of this PR have ZERO impact on the userland (invisible for users)
    • Option 2: atomic delivery: the changes is atomic and complete (no partial delivery)

@henri-ly henri-ly requested review from a team as code owners May 11, 2022 08:54
@henri-ly henri-ly changed the title Feat/live 1940 Feat/live 1940 Rework of staking flow for ATOM May 11, 2022
package.json Outdated
@@ -49,7 +49,7 @@
"@ledgerhq/hw-transport": "6.27.1",
"@ledgerhq/hw-transport-http": "6.27.1",
"@ledgerhq/hw-transport-node-hid-singleton": "6.27.1",
"@ledgerhq/live-common": "22.0.3",
"@ledgerhq/live-common": "https://github.com/LedgerHQ/ledger-live-common.git#d5349a0291fcab0663406c29772c6f1a3376ac99",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll revert I need it to provide build for QA / PO

@ghost ghost changed the title Feat/live 1940 Rework of staking flow for ATOM LIVE-1940 Rework of staking flow for ATOM May 12, 2022
@github-actions
Copy link

github-actions bot commented May 13, 2022

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 23.46% 38/162
🔴 Branches 20.51% 8/39
🔴 Functions 3.64% 2/55
🔴 Lines 24.16% 36/149

Test suite run success

2 tests passing in 2 suites.

Report generated by 🧪jest coverage report action from 4b0d47a

@ghost
Copy link

ghost commented May 16, 2022

/generate-screenshots

@github-actions
Copy link

@henri-ly henri-ly requested a review from a team as a code owner May 16, 2022 12:18
@ghost
Copy link

ghost commented May 17, 2022

/generate-screenshots

@github-actions
Copy link

@ghost ghost added the feature ready label May 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants