This repository has been archived by the owner on Jun 16, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 301
LIVE-1940 Rework of staking flow for ATOM #4972
Open
henri-ly
wants to merge
10
commits into
develop
Choose a base branch
from
feat/LIVE-1940
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henri-ly
changed the title
Feat/live 1940
Feat/live 1940 Rework of staking flow for ATOM
May 11, 2022
henri-ly
commented
May 11, 2022
package.json
Outdated
@@ -49,7 +49,7 @@ | |||
"@ledgerhq/hw-transport": "6.27.1", | |||
"@ledgerhq/hw-transport-http": "6.27.1", | |||
"@ledgerhq/hw-transport-node-hid-singleton": "6.27.1", | |||
"@ledgerhq/live-common": "22.0.3", | |||
"@ledgerhq/live-common": "https://github.com/LedgerHQ/ledger-live-common.git#d5349a0291fcab0663406c29772c6f1a3376ac99", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll revert I need it to provide build for QA / PO
ghost
reviewed
May 11, 2022
src/renderer/families/cosmos/DelegationFlowModal/steps/StepDelegation.js
Show resolved
Hide resolved
src/renderer/families/cosmos/DelegationFlowModal/fields/ValidatorField.js
Show resolved
Hide resolved
src/renderer/families/cosmos/DelegationFlowModal/components/ValidatorRow.js
Outdated
Show resolved
Hide resolved
ghost
changed the title
Feat/live 1940 Rework of staking flow for ATOM
LIVE-1940 Rework of staking flow for ATOM
May 12, 2022
Coverage report
Test suite run success2 tests passing in 2 suites.Report generated by 🧪jest coverage report action from 4b0d47a |
/generate-screenshots |
ghost
approved these changes
May 17, 2022
/generate-screenshots |
ghost
added
the
feature ready
label
May 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦒 Context (issues, jira)
💻 Description / Demo (image or video)
Rework of validator flow for Cosmos according to the Figma
🖤 Expectations to reach
PR must pass CI, rebase develop if conflicts. Thanks!