fix: base64 encode vfile buffers in html export (marimo-team#1441)

Fixes a bug in which notebooks containing images and other media couldn't be exported as HTML
Light2Dark · May 22, 2024 · da6675d · da6675d
1 parent 29338ee
commit da6675d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/marimo/_output/utils.py b/marimo/_output/utils.py
@@ -8,6 +8,7 @@
 
 
 def build_data_url(mimetype: KnownMimeType, data: bytes) -> str:
+    # `data` must be base64 encoded
     str_repr = data.decode("utf-8").replace("\n", "")
     return f"data:{mimetype};base64,{str_repr}"
 

diff --git a/marimo/_server/export/exporter.py b/marimo/_server/export/exporter.py
@@ -1,6 +1,7 @@
 # Copyright 2024 Marimo. All rights reserved.
 from __future__ import annotations
 
+import base64
 import io
 import mimetypes
 import os
@@ -61,7 +62,8 @@ def export_as_html(
                 None,
             )
             files[filename_and_length] = build_data_url(
-                cast(KnownMimeType, mime_type), buffer_contents
+                cast(KnownMimeType, mime_type),
+                base64.b64encode(buffer_contents),
             )
 
         config = _deep_copy(DEFAULT_CONFIG)