-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add email callback on train complete #20162
Open
loucaspapalazarou
wants to merge
9
commits into
Lightning-AI:master
Choose a base branch
from
loucaspapalazarou:feature/email-callback-on-train-done
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add email callback on train complete #20162
loucaspapalazarou
wants to merge
9
commits into
Lightning-AI:master
from
loucaspapalazarou:feature/email-callback-on-train-done
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loucaspapalazarou
requested review from
lantiga,
Borda,
tchaton,
awaelchli and
justusschock
as code owners
August 4, 2024 17:57
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20162 +/- ##
=========================================
- Coverage 89% 81% -8%
=========================================
Files 267 265 -2
Lines 23064 23062 -2
=========================================
- Hits 20573 18626 -1947
- Misses 2491 4436 +1945 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a new callback that allows a user to notify a list of emails when the training is done. It currently only supports the Google SMTP and is recommended to use an app password. Adding more providers is trivial. If the feedback is positive, I will go ahead and add the docs update as well as proper tests.
Resolves #20133
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20162.org.readthedocs.build/en/20162/