Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(benchmarks): runtime utility function + timestamp set benchmarks #330

Merged
merged 8 commits into from
Jan 16, 2024

Conversation

radkomih
Copy link
Collaborator

@radkomih radkomih commented Jan 8, 2024

Detailed description:

Check the issue

Which issue(s) this PR fixes:
Fixes #327 #326

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@radkomih radkomih self-assigned this Jan 8, 2024
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d13953a) 80.94% compared to head (ec155ce) 80.95%.

Files Patch % Lines
primitives/types/raw_origin.go 83.33% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #330   +/-   ##
========================================
  Coverage    80.94%   80.95%           
========================================
  Files          164      164           
  Lines        10654    10672   +18     
========================================
+ Hits          8624     8639   +15     
- Misses        1738     1740    +2     
- Partials       292      293    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@radkomih radkomih force-pushed the initial-bench-prototype branch from 6f44fac to 581320f Compare January 8, 2024 09:44
env/utils_benchmarks.go Outdated Show resolved Hide resolved
@radkomih radkomih force-pushed the initial-bench-prototype branch 6 times, most recently from 86b09b6 to 4fea4df Compare January 11, 2024 12:58
@radkomih radkomih requested review from failfmi and tgntr January 11, 2024 12:59
@radkomih radkomih changed the title feat(benchmarks): runtime utility function and host imports feat(benchmarks): runtime utility function + timestamp set benchmarks Jan 12, 2024
failfmi
failfmi previously approved these changes Jan 12, 2024
runtime/benchmark_runtime_test.go Outdated Show resolved Hide resolved
tgntr
tgntr previously approved these changes Jan 16, 2024
@radkomih radkomih force-pushed the initial-bench-prototype branch from 827dfa2 to ec155ce Compare January 16, 2024 14:02
@failfmi failfmi self-requested a review January 16, 2024 14:04
@radkomih radkomih merged commit 768722f into develop Jan 16, 2024
5 checks passed
@radkomih radkomih deleted the initial-bench-prototype branch January 16, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants