Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modules): babe #405

Merged
merged 6 commits into from
Apr 22, 2024
Merged

feat(modules): babe #405

merged 6 commits into from
Apr 22, 2024

Conversation

radkomih
Copy link
Collaborator

@radkomih radkomih commented Apr 18, 2024

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context,
including:

  • What does this PR do?
  • api
    • BabeApi_configuration
    • BabeApi_current_epoch_start
    • BabeApi_current_epoch
    • BabeApi_next_epoch
    • BabeApi_generate_key_ownership_proof
    • BabeApi_submit_report_equivocation_unsigned_extrinsic
    • metadata
    • unit tests
    • integration tests
  • babe module
    • calls
      • plan_config_change
      • report_equivocation is not implemented
      • report_equivocation_unsigned is not implemented
    • storage
    • errors
    • metadata
    • unit tests (needs more coverage)
    • integration tests
    • benchmark tests
  • build process
    • support building multiple templates
  • gossamer integration

Use Github semantic linking to address any open issues this PR relates to or closes.

Fixes #368 #369 #371 #370

ToDo #406

Checklist:

  • I have read the contributing guidelines.
  • My PR title matches the Conventional Commits spec.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I can start a Substrate node using the updated runtime.

@radkomih radkomih self-assigned this Apr 18, 2024
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 68.88757% with 523 lines in your changes are missing coverage. Please review.

Project coverage is 81.08%. Comparing base (c0a84d3) to head (798da16).

Files Patch % Lines
frame/babe/module.go 33.25% 263 Missing and 34 partials ⚠️
testhelpers/testhelpers.go 0.00% 52 Missing ⚠️
frame/babe/digest.go 74.81% 24 Missing and 10 partials ⚠️
primitives/types/public_key.go 0.00% 17 Missing ⚠️
api/babe/module.go 85.18% 9 Missing and 3 partials ⚠️
primitives/babe/configuration.go 68.42% 6 Missing and 6 partials ⚠️
primitives/babe/epoch.go 68.42% 6 Missing and 6 partials ⚠️
frame/babe/crypto.go 0.00% 10 Missing ⚠️
frame/babe/storage.go 66.66% 10 Missing ⚠️
frame/support/hash_storage_value.go 0.00% 8 Missing ⚠️
... and 13 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #405      +/-   ##
===========================================
- Coverage    83.92%   81.08%   -2.85%     
===========================================
  Files          242      270      +28     
  Lines        11692    13499    +1807     
===========================================
+ Hits          9813    10946    +1133     
- Misses        1479     2077     +598     
- Partials       400      476      +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@failfmi failfmi self-requested a review April 18, 2024 06:43
@radkomih radkomih force-pushed the feat/babe-module branch 6 times, most recently from 151ca85 to e2b2e9c Compare April 19, 2024 05:31
failfmi
failfmi previously approved these changes Apr 19, 2024
@failfmi failfmi merged commit 0cc0782 into develop Apr 22, 2024
6 of 8 checks passed
@failfmi failfmi deleted the feat/babe-module branch April 22, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

add babe module
2 participants