Support monolog v. 2 #1

gabfr · 2019-12-10T16:10:37Z

We need to support Monolog v. 2 in order to update the dependencies of LinioPay/API and LinioPay/Vault.

In order to do this, we need this package (monolog-cascade) to also support Monolog v. 2. After shifting the version on the composer.json, and running the php unit tests, we have some work ahead:

Rebase to the latest version of the original package theorchard/monolog-cascade
Upgrade tests to use the new PHP Unit base class (thanks @MarioDevment)
Fix mocks conflicting with the new HandlerLoader searching for a processor as an object not string (thanks again @MarioDevment)

…fixtures

Cleaned up Phpdocs, unused namespaces, fixed tests using Closures as …

* Replace symfony/serializer dependency with Util class * Fix indentation issue

`~3.0` covers `~3.1` as well because it is equivalent to `>=3.0.0.0-dev <4.0.0.0-dev`

Added link to Medium post in ReadMe

)

* Add support for symfony4 * fix travis.yml

Corrects a typo in the documentation.

rgdevment

the errors are for monolog compatibility, should not be causes of this PR.

The changes work for me, leave some small suggestions to fix.

composer.json

gabfr · 2019-12-10T20:10:32Z

Finally aligning the packages versions made the dummy error from the description disappear. Although now we have the following error and warnings to fix:

PHP Deprecated:  The each() function is deprecated. This message will be suppressed on further calls in /application/vendor/phpunit/phpunit/src/Util/Getopt.php on line 38
PHP Stack trace:
PHP   1. {main}() /application/vendor/phpunit/phpunit/phpunit:0
PHP   2. PHPUnit_TextUI_Command::main() /application/vendor/phpunit/phpunit/phpunit:47
PHP   3. PHPUnit_TextUI_Command->run() /application/vendor/phpunit/phpunit/src/TextUI/Command.php:113
PHP   4. PHPUnit_TextUI_Command->handleArguments() /application/vendor/phpunit/phpunit/src/TextUI/Command.php:124
PHP   5. PHPUnit_Util_Getopt::getopt() /application/vendor/phpunit/phpunit/src/TextUI/Command.php:249
PHP   6. each() /application/vendor/phpunit/phpunit/src/Util/Getopt.php:38
PHPUnit 5.4.8 by Sebastian Bergmann and contributors.

.................E...........................WWWWWWWWWWWWWWWWWWWW 65 / 91 ( 71%)
W....WWWWWWWWW............                                        91 / 91 (100%)

Time: 1.86 seconds, Memory: 4.00MB

There was 1 error:

1) Cascade\Tests\Config\Loader\ClassLoader\HandlerLoaderTest::testHandlerForProcessor
TypeError: Argument 1 passed to Mock_TestHandler_c8e32ff4::pushProcessor() must be callable, string given, called in /application/src/Config/Loader/ClassLoader/HandlerLoader.php on line 188

/application/src/Config/Loader/ClassLoader/HandlerLoader.php:188
/application/tests/Config/Loader/ClassLoader/HandlerLoaderTest.php:258

--

There were 30 warnings:

1) Cascade\Tests\Config\Loader\FileLoader\FileLoaderAbstractTest::testReadFrom
PHPUnit_Framework_TestCase::getMock() is deprecated, use PHPUnit_Framework_TestCase::createMock() or PHPUnit_Framework_TestCase::getMockBuilder() instead

2) Cascade\Tests\Config\Loader\FileLoader\FileLoaderAbstractTest::testLoadFileFromString
PHPUnit_Framework_TestCase::getMock() is deprecated, use PHPUnit_Framework_TestCase::createMock() or PHPUnit_Framework_TestCase::getMockBuilder() instead

3) Cascade\Tests\Config\Loader\FileLoader\FileLoaderAbstractTest::testValidateExtension with data set #0 (true, 'hello/world.test')
PHPUnit_Framework_TestCase::getMock() is deprecated, use PHPUnit_Framework_TestCase::createMock() or PHPUnit_Framework_TestCase::getMockBuilder() instead

4) Cascade\Tests\Config\Loader\FileLoader\FileLoaderAbstractTest::testValidateExtension with data set #1 (true, 'hello/world.php')
PHPUnit_Framework_TestCase::getMock() is deprecated, use PHPUnit_Framework_TestCase::createMock() or PHPUnit_Framework_TestCase::getMockBuilder() instead

5) Cascade\Tests\Config\Loader\FileLoader\FileLoaderAbstractTest::testValidateExtension with data set #2 (false, 'hello/world.jpeg')
PHPUnit_Framework_TestCase::getMock() is deprecated, use PHPUnit_Framework_TestCase::createMock() or PHPUnit_Framework_TestCase::getMockBuilder() instead

6) Cascade\Tests\Config\Loader\FileLoader\FileLoaderAbstractTest::testValidateExtension with data set #3 (false, 'hello/world')
PHPUnit_Framework_TestCase::getMock() is deprecated, use PHPUnit_Framework_TestCase::createMock() or PHPUnit_Framework_TestCase::getMockBuilder() instead

7) Cascade\Tests\Config\Loader\FileLoader\FileLoaderAbstractTest::testValidateExtension with data set #4 (false, '')
PHPUnit_Framework_TestCase::getMock() is deprecated, use PHPUnit_Framework_TestCase::createMock() or PHPUnit_Framework_TestCase::getMockBuilder() instead

8) Cascade\Tests\Config\Loader\FileLoader\FileLoaderAbstractTest::testGetSectionOf with data set #0 (array(array('AA', 'AB'), array('BA', 'BB')), 'b', array('BA', 'BB'))
PHPUnit_Framework_TestCase::getMock() is deprecated, use PHPUnit_Framework_TestCase::createMock() or PHPUnit_Framework_TestCase::getMockBuilder() instead

9) Cascade\Tests\Config\Loader\FileLoader\FileLoaderAbstractTest::testGetSectionOf with data set #1 (array('A', 'B'), 'c', array('A', 'B'))
PHPUnit_Framework_TestCase::getMock() is deprecated, use PHPUnit_Framework_TestCase::createMock() or PHPUnit_Framework_TestCase::getMockBuilder() instead

10) Cascade\Tests\Config\Loader\FileLoader\FileLoaderAbstractTest::testGetSectionOf with data set #2 (array('A', 'B'), '', array('A', 'B'))
PHPUnit_Framework_TestCase::getMock() is deprecated, use PHPUnit_Framework_TestCase::createMock() or PHPUnit_Framework_TestCase::getMockBuilder() instead

11) Cascade\Tests\Config\Loader\FileLoader\FileLoaderAbstractTest::testloadFileFromInvalidFile
PHPUnit_Framework_TestCase::getMock() is deprecated, use PHPUnit_Framework_TestCase::createMock() or PHPUnit_Framework_TestCase::getMockBuilder() instead

12) Cascade\Tests\Config\Loader\FileLoader\JsonTest::testLoad
PHPUnit_Framework_TestCase::getMock() is deprecated, use PHPUnit_Framework_TestCase::createMock() or PHPUnit_Framework_TestCase::getMockBuilder() instead

13) Cascade\Tests\Config\Loader\FileLoader\JsonTest::testSupportsWithInvalidResource with data set #0 (array())
PHPUnit_Framework_TestCase::getMock() is deprecated, use PHPUnit_Framework_TestCase::createMock() or PHPUnit_Framework_TestCase::getMockBuilder() instead

14) Cascade\Tests\Config\Loader\FileLoader\JsonTest::testSupportsWithInvalidResource with data set #1 (true)
PHPUnit_Framework_TestCase::getMock() is deprecated, use PHPUnit_Framework_TestCase::createMock() or PHPUnit_Framework_TestCase::getMockBuilder() instead

15) Cascade\Tests\Config\Loader\FileLoader\JsonTest::testSupportsWithInvalidResource with data set #2 (123)
PHPUnit_Framework_TestCase::getMock() is deprecated, use PHPUnit_Framework_TestCase::createMock() or PHPUnit_Framework_TestCase::getMockBuilder() instead

16) Cascade\Tests\Config\Loader\FileLoader\JsonTest::testSupportsWithInvalidResource with data set #3 (123.456)
PHPUnit_Framework_TestCase::getMock() is deprecated, use PHPUnit_Framework_TestCase::createMock() or PHPUnit_Framework_TestCase::getMockBuilder() instead

17) Cascade\Tests\Config\Loader\FileLoader\JsonTest::testSupportsWithInvalidResource with data set #4 (null)
PHPUnit_Framework_TestCase::getMock() is deprecated, use PHPUnit_Framework_TestCase::createMock() or PHPUnit_Framework_TestCase::getMockBuilder() instead

18) Cascade\Tests\Config\Loader\FileLoader\JsonTest::testSupportsWithInvalidResource with data set #5 (stdClass Object ())
PHPUnit_Framework_TestCase::getMock() is deprecated, use PHPUnit_Framework_TestCase::createMock() or PHPUnit_Framework_TestCase::getMockBuilder() instead

19) Cascade\Tests\Config\Loader\FileLoader\JsonTest::testSupportsWithJsonString
PHPUnit_Framework_TestCase::getMock() is deprecated, use PHPUnit_Framework_TestCase::createMock() or PHPUnit_Framework_TestCase::getMockBuilder() instead

20) Cascade\Tests\Config\Loader\FileLoader\JsonTest::testSupportsWithJsonFile
PHPUnit_Framework_TestCase::getMock() is deprecated, use PHPUnit_Framework_TestCase::createMock() or PHPUnit_Framework_TestCase::getMockBuilder() instead

21) Cascade\Tests\Config\Loader\FileLoader\JsonTest::testSupportsWithNonJsonString
PHPUnit_Framework_TestCase::getMock() is deprecated, use PHPUnit_Framework_TestCase::createMock() or PHPUnit_Framework_TestCase::getMockBuilder() instead

22) Cascade\Tests\Config\Loader\FileLoader\YamlTest::testLoad
PHPUnit_Framework_TestCase::getMock() is deprecated, use PHPUnit_Framework_TestCase::createMock() or PHPUnit_Framework_TestCase::getMockBuilder() instead

23) Cascade\Tests\Config\Loader\FileLoader\YamlTest::testSupportsWithInvalidResource with data set #0 (array())
PHPUnit_Framework_TestCase::getMock() is deprecated, use PHPUnit_Framework_TestCase::createMock() or PHPUnit_Framework_TestCase::getMockBuilder() instead

24) Cascade\Tests\Config\Loader\FileLoader\YamlTest::testSupportsWithInvalidResource with data set #1 (true)
PHPUnit_Framework_TestCase::getMock() is deprecated, use PHPUnit_Framework_TestCase::createMock() or PHPUnit_Framework_TestCase::getMockBuilder() instead

25) Cascade\Tests\Config\Loader\FileLoader\YamlTest::testSupportsWithInvalidResource with data set #2 (123)
PHPUnit_Framework_TestCase::getMock() is deprecated, use PHPUnit_Framework_TestCase::createMock() or PHPUnit_Framework_TestCase::getMockBuilder() instead

26) Cascade\Tests\Config\Loader\FileLoader\YamlTest::testSupportsWithInvalidResource with data set #3 (123.456)
PHPUnit_Framework_TestCase::getMock() is deprecated, use PHPUnit_Framework_TestCase::createMock() or PHPUnit_Framework_TestCase::getMockBuilder() instead

27) Cascade\Tests\Config\Loader\FileLoader\YamlTest::testSupportsWithInvalidResource with data set #4 (null)
PHPUnit_Framework_TestCase::getMock() is deprecated, use PHPUnit_Framework_TestCase::createMock() or PHPUnit_Framework_TestCase::getMockBuilder() instead

28) Cascade\Tests\Config\Loader\FileLoader\YamlTest::testSupportsWithInvalidResource with data set #5 (stdClass Object ())
PHPUnit_Framework_TestCase::getMock() is deprecated, use PHPUnit_Framework_TestCase::createMock() or PHPUnit_Framework_TestCase::getMockBuilder() instead

29) Cascade\Tests\Config\Loader\FileLoader\YamlTest::testSupportsWithYamlString
PHPUnit_Framework_TestCase::getMock() is deprecated, use PHPUnit_Framework_TestCase::createMock() or PHPUnit_Framework_TestCase::getMockBuilder() instead

30) Cascade\Tests\Config\Loader\FileLoader\YamlTest::testSupportsWithYamlFile
PHPUnit_Framework_TestCase::getMock() is deprecated, use PHPUnit_Framework_TestCase::createMock() or PHPUnit_Framework_TestCase::getMockBuilder() instead

ERRORS!
Tests: 91, Assertions: 121, Errors: 1, Warnings: 30.

The problem was with the old PHP Unit Test Case base class

chore: update symfony/serializer version

Raphael Antonmattei and others added 13 commits March 18, 2016 17:03

Cleaned up Phpdocs, unused namespaces, fixed tests using Closures as …

655f881

…fixtures

Merge pull request theorchard#60 from rantonmattei/cleanup

4641f86

Cleaned up Phpdocs, unused namespaces, fixed tests using Closures as …

Replace symfony/serializer dependency with Util class (theorchard#67)

491aaf8

* Replace symfony/serializer dependency with Util class * Fix indentation issue

changes for symfony 3 (theorchard#68)

81e756f

Removed unnecessary symfony version constraint (theorchard#69)

c67e060

`~3.0` covers `~3.1` as well because it is equivalent to `>=3.0.0.0-dev <4.0.0.0-dev`

Added link to Medium post in ReadMe (theorchard#72)

16e88ae

Added link to Medium post in ReadMe

Several phpdoc fixes (theorchard#74)

8a2c927

Added aliases for Cascade::fileConfig (theorchard#75)

c40260d

Update branch alias for dev-master in composer.json file. (theorchard#76

4054bd4

)

Add support for symfony4 (theorchard#81)

211b722

* Add support for symfony4 * fix travis.yml

fix issue theorchard#78 (theorchard#79)

9b46361

Corrects a typo in the documentation.

composer: allow semver package upgrades (theorchard#88)

5353e00

fixed logger name in README.md (theorchard#85)

39ff6a4

pr-triage bot added the PR: draft label Dec 10, 2019

rgdevment reviewed Dec 10, 2019

View reviewed changes

composer.json Outdated Show resolved Hide resolved

pr-triage bot added PR: unreviewed PR: draft and removed PR: draft PR: unreviewed labels Dec 10, 2019

gabfr force-pushed the feat/support-monolog-2 branch from 8d0de12 to a75ac03 Compare December 11, 2019 15:24

gabfr added 2 commits December 11, 2019 12:27

feature: update monolog and other dependencies to support v. 2

e55d410

refactor: applying @MarioDevment patch to support phpunit 5+

461995b

gabfr force-pushed the feat/support-monolog-2 branch from a75ac03 to 461995b Compare December 11, 2019 15:29

fix: UtilTest that came with rebase

4ae3e87

The problem was with the old PHP Unit Test Case base class

gabfr marked this pull request as ready for review December 11, 2019 15:31

pr-triage bot added PR: unreviewed and removed PR: draft labels Dec 11, 2019

Merge branch 'master' into feat/support-monolog-2

7fa3b7a

klaussilveira approved these changes Dec 11, 2019

View reviewed changes

pr-triage bot added PR: reviewed-approved and removed PR: unreviewed labels Dec 11, 2019

paulotokimatu approved these changes Dec 12, 2019

View reviewed changes

klaussilveira merged commit 0fe8458 into LinioIT:master Dec 12, 2019

pr-triage bot added PR: merged and removed PR: reviewed-approved labels Dec 12, 2019

klaussilveira pushed a commit that referenced this pull request Dec 16, 2022

Merge pull request #1 from Felynx3/update-dependence

a55846b

chore: update symfony/serializer version

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support monolog v. 2 #1

Support monolog v. 2 #1

gabfr commented Dec 10, 2019 •

edited

Loading

rgdevment left a comment

gabfr commented Dec 10, 2019 •

edited

Loading

Support monolog v. 2 #1

Support monolog v. 2 #1

Conversation

gabfr commented Dec 10, 2019 • edited Loading

rgdevment left a comment

Choose a reason for hiding this comment

gabfr commented Dec 10, 2019 • edited Loading

gabfr commented Dec 10, 2019 •

edited

Loading

gabfr commented Dec 10, 2019 •

edited

Loading