Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSOE-708: Email Quota Management UX improvements in Lombiq.Hosting.Tenants #102

Merged
merged 5 commits into from
Nov 27, 2023
Merged

OSOE-708: Email Quota Management UX improvements in Lombiq.Hosting.Tenants #102

merged 5 commits into from
Nov 27, 2023
+19 −22

Conversation

wAsnk
Copy link
Member

@wAsnk wAsnk commented Nov 23, 2023 •
edited by jira bot
Loading

OSOE-708
Fixes #94

@wAsnk wAsnk changed the title OSOE-708: Email Quota Management UX improvements in Lombiq.Hosting.Tenants OSOE-708: Email Quota Management UX improvements Nov 23, 2023
@github-actions github-actions bot changed the title OSOE-708: Email Quota Management UX improvements OSOE-708: Email Quota Management UX improvements in Lombiq.Hosting.Tenants Nov 23, 2023
@Psichorex
Copy link
Contributor

My only question here is that the original feature was about to display a message about the quota on the dashboard. This feature was extended to show up not only on the dashboard but all the admin pages. I think the UITest should cover that because it is only checking on the dashboard which is the original feature but not the extended. Otherwise approved.

@wAsnk
Copy link
Member Author

wAsnk commented Nov 27, 2023

My only question here is that the original feature was about to display a message about the quota on the dashboard. This feature was extended to show up not only on the dashboard but all the admin pages. I think the UITest should cover that because it is only checking on the dashboard which is the original feature but not the extended. Otherwise approved.

Yeah you are right, I'll adjust it with some additional admin pages to check.

@Psichorex Psichorex merged commit adb4e3f into dev Nov 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Psichorex Psichorex Psichorex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Email Quota Management UX improvements (OSOE-708)
2 participants
@wAsnk @Psichorex