Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSOE-848: EmailQuotaService has unnecessary ISession.SaveAsync() calls in Lombiq.Hosting.Tenants #125

Merged
merged 2 commits into from
Jun 16, 2024
Merged

OSOE-848: EmailQuotaService has unnecessary ISession.SaveAsync() calls in Lombiq.Hosting.Tenants #125

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13d2b3c
Adding explaining comment to avoid removing SaveAsync()
Psichorex Jun 16, 2024
4de4b22
Spelling/grammar
Piedone Jun 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Lombiq.Hosting.Tenants.EmailQuotaManagement/Services/EmailQuotaService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@

namespace Lombiq.Hosting.Tenants.EmailQuotaManagement.Services;

// As noted under the GitHub issue https://github.com/OrchardCMS/OrchardCore/issues/15290#issuecomment-2093363619
// SaveAsync calls could be removed due to redundancy, however, removing them actually breaks functionality.
public class EmailQuotaService : IEmailQuotaService
{
private readonly ISession _session;
Expand Down