Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSOE-629: Test Features Guard with recipe import too #71

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Conversation

Piedone
Copy link
Member

@Piedone Piedone commented Jun 12, 2023

OSOE-629
Fixes #61

@github-actions github-actions bot changed the title Test Features Guard with recipe import too OSOE-629: Test Features Guard with recipe import too Jun 12, 2023
@Psichorex
Copy link
Contributor

Psichorex commented Jun 14, 2023

I think we should also include a test which is retrieving the Dictionary from the appsettings.json and simultaneously from the Program.cs because currently the json part is not tested as per getting it from the appsettings directly.
But that one will only work as desired after we merge the latest changes into Hosting Tenants with the OC 1.6 upgrade branch so OSOE-548 in PR #55
What dou think?

@Piedone
Copy link
Member Author

Piedone commented Jun 14, 2023

Both of these configurations are really the same thing: when you add a config to appsettings, it'll be loaded into the same IShellConfiguration that you directly interact with from Program. I don't really see a point testing that (while it's theoretically possibly that something break in this, that would mean that something is fundamentally broken in ASP.NET Core or OC, what we'd notice by all UI tests, since they all rely on such config working, breaking).

@Psichorex Psichorex merged commit a82bcb8 into dev Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Features Guard with recipe import too (OSOE-629)
2 participants