OSOE-84: Migrate to Node.js Extensions #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
September 29, 2022 22:26
# Conflicts: # Lombiq.DataTables/Lombiq.DataTables.csproj
sarahelsaig
requested changes
Oct 19, 2022
|
I think you weren't supposed to delete the Lombiq.DataTables/wwwroot/.placeholder file too? |
Why would we keep them? We don't need the wwwroot folder in the repo anymore. Adding the generated files to the assembly is now being taken care of by NE. |
|
For some reason that .placeholder existed well before we started committing the built files. |
|
I haven't needed it ever since I've removed it. |
sarahelsaig
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSOE-84