fix: thorvg engine init and termination with reference counting of renderers #265
+146
−2,195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theashraf
force-pushed
the
fix/tvg_engine_term
branch
from
aac6e34 to
52829ff
Compare
|
dragostis
reviewed
Nov 27, 2024
theashraf
force-pushed
the
fix/tvg_engine_term
branch
2 times, most recently
from
af9d870 to
faaf468
Compare
theashraf
force-pushed
the
fix/tvg_engine_term
branch
from
04a9892 to
196e655
Compare
samuelOsborne
force-pushed
the
fix/tvg_engine_term
branch
from
196e655 to
09b4410
Compare
theashraf
force-pushed
the
fix/tvg_engine_term
branch
2 times, most recently
from
2ec3604 to
e7810ef
Compare
dragostis
approved these changes
Dec 9, 2024
| use std::thread; | ||
|
|
||
| #[test] | ||
| fn test_tvg_renderer_no_deadlock() { |
There was a problem hiding this comment.
Just a nit: this test might not actually capture a deadlock, so you can have false negatives here. It's still useful as a smoke test, but it might lead to a case like this:
- Alice make a PR with a concurrency bug, but the test happens to pass and is merged.
- Bob makes another PR that has nothing to do with concurrency, but his PR fails this regression test.
Up to you what you wanna do with it. :)
theashraf
force-pushed
the
fix/tvg_engine_term
branch
from
e226d0c to
aeab801
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update ensures that
tvg_engine_initis called only once, provided no renderers are already created. It also ensures thattvg_engine_termis called when the last renderer is dropped, resolving an issue where creating a new renderer would unnecessarily reinitialize the engine and dropping it would attempt to terminate it again