Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Npcs are counted as ambient mobs #995

Open
RobertSkalko opened this issue Sep 26, 2024 · 0 comments
Open

Npcs are counted as ambient mobs #995

RobertSkalko opened this issue Sep 26, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@RobertSkalko
Copy link

I had a weird report today of your npcs not working properly with my mod.

Turns out they are counted as ambient mobs here

.<VillagerEntityMCA>create((t, w) -> new VillagerEntityMCA(t, w, Gender.MALE), SpawnGroup.AMBIENT)

Now i'm not totally sure about this but i think ambient spawngroup is for well mobs that are spawned just for ambience? Minecraft villagers use the MISC group btw

This isn't really a bug technically but it's probably a good idea to change it anyway i think

Oh, and the bug was on my side really, I didn't send client sync packets for ambient mobs for performance reasons. I assumed other mods wouldn't label their npcs as ambient mobs.

Feel free to close this if you have a reason to label them as ambient, but i'd be curious to know what it is.

@RobertSkalko RobertSkalko added the bug Something isn't working label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant