Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: refactor #2608

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

s0me1newithhand7s
Copy link

  • Yes i've tested locally

Why

  1. Edited shebangs to be right, as calling binaries trough env is right way.
  2. Switched to golang:bookworm in builder and ubuntu:latest in 3x-ui itself. It isn't so important for builder, but for x-ui.sh itself - it is.

s0me1newithhand7s and others added 2 commits November 29, 2024 19:46
	modified:   DockerInit.sh
	modified:   Dockerfile
	modified:   install.sh
	modified:   x-ui.sh
@s0me1newithhand7s
Copy link
Author

i can rebase if needed

@aski425
Copy link

aski425 commented Nov 29, 2024

please, it to "bookworm", because after I accidentally drop it, it is not convenient to restore it, because you have to do everything from the beginning, I would like it to be possible through cli and with docker can be done.

@s0me1newithhand7s
Copy link
Author

and pls don't silently close this PR
i am open to cooperate

@KiGamji
Copy link

KiGamji commented Dec 2, 2024

why would you switch from a smaller, lighter distro, to debian and ubuntu

@s0me1newithhand7s
Copy link
Author

why would you switch from a smaller, lighter distro, to debian and ubuntu

"Switched to golang:bookworm in builder and ubuntu:latest in 3x-ui itself. It isn't so important for builder, but for x-ui.sh itself - it is."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants