Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add progress indicator #2

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add progress indicator #2

wants to merge 2 commits into from

Conversation

TomAllenBerg
Copy link
Contributor

I created a progress indicator component that can be reused throughout the app.
image

@blf885 As a good practice, when code reviewing, checkout the branch and run it locally. You'd typically want to try to break the feature by trying things from a browser (e.g. for a form entering different inputs, etc..). In this case, there isn't much to break.

In addition, look through all of the code files that were changed in this PR and you'd want to call out any issues or errors you see before approving (or if you can think of a much better way to do something).

Copy link

@jlammilliman jlammilliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good shit as usual

},
data() {
return {
isCompleted: this.done // TODO - Set this value dynamically

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can probably remove the Todo here. Reason being: 'done' will (I assume) be bound to the parent calling whatever instance this is referencing. So in the component here we can trust that this value will be reliable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants