cmake: add USE_SYSTEM_* options; support find_package(pthreadpool) #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 tasks
ConnorBaker
force-pushed
the
feat/use-system-libs
branch
4 times, most recently
from
c3cb073
to
a531c1b
Compare
ConnorBaker
force-pushed
the
feat/use-system-libs
branch
7 times, most recently
from
d7c1425
to
8fc7c96
Compare
ConnorBaker
force-pushed
the
feat/use-system-libs
branch
from
8fc7c96
to
f320027
Compare
|
Updated to reflect comment from pytorch/cpuinfo#153 (comment). @Maratyszcza if you have the time, would you mind reviewing this? |
|
I'd be interested in seeing this merged as well since we need this change for the https://github.com/google/ml-compiler-opt project. @Maratyszcza would it be possible to take a look? |
petrhosek
reviewed
Feb 14, 2024
| @@ -0,0 +1,5 @@ | |||
| @PACKAGE_INIT@ | |||
There was a problem hiding this comment.
I believe this also needs the following prior to this line to make sure FXdiv is present:
Suggested change
| @PACKAGE_INIT@ | |
| include(CMakeFindDependencyMacro) | |
| find_dependency(FXdiv) | |
| @PACKAGE_INIT@ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the work done in pytorch/pytorch#37137, this adds the following CMake options:
USE_SYSTEM_LIBSUSE_SYSTEM_GOOGLEBENCHMARKUSE_SYSTEM_GOOGLETESTUSE_SYSTEM_FXDIVThis is particularly useful in the context of Nix, where we can build these libraries once and then re-use them elsewhere to avoid rebuilding vendors dependencies.
Additionally, adds a CMake configuration file to make it possible for CMake-based projects to use
find_packageto consume this library.